Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README Snippet Use of deployment_principal_arns #172

Merged
merged 3 commits into from
Jun 28, 2021
Merged

Fix README Snippet Use of deployment_principal_arns #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fc0249
Fix deployment_principal_arns variable in README snippet.
korenyoni Jun 28, 2021
49d6cd6
fix wording leading up to snippets in README.
korenyoni Jun 28, 2021
4c2d894
Auto Format
cloudpossebot Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ For a complete example, see [examples/complete](examples/complete).

For automated tests of the complete example using [bats](https://github.com/bats-core/bats-core) and [Terratest](https://github.com/gruntwork-io/terratest) (which tests and deploys the example on AWS), see [test](test).

This will create a new s3 bucket `eg-prod-app` for a cloudfront cdn, and allow `principal1` to upload to
The following will create a new s3 bucket `eg-prod-app` for a cloudfront cdn, and allow `principal1` to upload to
`prefix1` and `prefix2`, while allowing `principal2` to manage the whole bucket.

```hcl
Expand All @@ -115,13 +115,13 @@ module "cdn" {
parent_zone_name = "cloudposse.com"

deployment_principal_arns = {
"arn:aws:s3:::principal1" = ["prefix1/", "prefix2/"]
"arn:aws:s3:::principal2" = [""]
"arn:aws:iam::123456789012:role/principal1" = ["prefix1/", "prefix2/"]
"arn:aws:iam::123456789012:role/principal2" = [""]
}
}
```

This will reuse an existing s3 bucket `eg-prod-app` for a cloudfront cdn.
The following will reuse an existing s3 bucket `eg-prod-app` for a cloudfront cdn.

```hcl
module "cdn" {
Expand Down
8 changes: 4 additions & 4 deletions README.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ usage: |-

For automated tests of the complete example using [bats](https://github.com/bats-core/bats-core) and [Terratest](https://github.com/gruntwork-io/terratest) (which tests and deploys the example on AWS), see [test](test).

This will create a new s3 bucket `eg-prod-app` for a cloudfront cdn, and allow `principal1` to upload to
The following will create a new s3 bucket `eg-prod-app` for a cloudfront cdn, and allow `principal1` to upload to
`prefix1` and `prefix2`, while allowing `principal2` to manage the whole bucket.

```hcl
Expand All @@ -80,13 +80,13 @@ usage: |-
parent_zone_name = "cloudposse.com"

deployment_principal_arns = {
"arn:aws:s3:::principal1" = ["prefix1/", "prefix2/"]
"arn:aws:s3:::principal2" = [""]
"arn:aws:iam::123456789012:role/principal1" = ["prefix1/", "prefix2/"]
"arn:aws:iam::123456789012:role/principal2" = [""]
}
}
```

This will reuse an existing s3 bucket `eg-prod-app` for a cloudfront cdn.
The following will reuse an existing s3 bucket `eg-prod-app` for a cloudfront cdn.

```hcl
module "cdn" {
Expand Down