Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Bump Dependency Module Versions #201

Merged
merged 5 commits into from
Dec 13, 2021
Merged

Chore: Bump Dependency Module Versions #201

merged 5 commits into from
Dec 13, 2021

Conversation

korenyoni
Copy link
Member

@korenyoni korenyoni commented Dec 13, 2021 •
edited by Nuru
Loading

what

  • Bump route53-alias module version to latest.
  • Bump s3-log-storage module to latest.

why

  • Dependency modules do not currently support tenant label (they are not at the version which supports it).
  • General module hygiene: keep dependency modules up to date.

references

@korenyoni korenyoni added the patch A minor, backward compatible change label Dec 13, 2021
@korenyoni korenyoni requested review from a team as code owners December 13, 2021 07:35
@korenyoni korenyoni requested a review from max-lobur December 13, 2021 07:36
@korenyoni korenyoni requested a review from a team as a code owner December 13, 2021 07:36
@korenyoni korenyoni requested review from jhosteny and removed request for a team December 13, 2021 07:36
@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni requested a review from a team as a code owner December 13, 2021 08:27
@Nuru
Copy link
Contributor

Nuru commented Dec 13, 2021

/test all

Nuru
Nuru previously approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@Nuru Nuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as-is, but consider incorporating some other open PRs and fixing some other open issues in this same, on PR, so we get more fixed in the one release.

max-lobur
max-lobur previously approved these changes Dec 13, 2021
View reviewed changes
@korenyoni korenyoni removed the patch A minor, backward compatible change label Dec 13, 2021
@korenyoni korenyoni mentioned this pull request Dec 13, 2021
Merged
@korenyoni
Copy link
Member Author

/test all

@mergify mergify bot dismissed stale reviews from Nuru and max-lobur December 13, 2021 15:27

This Pull Request has been updated, so we're dismissing all reviews.

@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni added chore no-release Do not create a new release (wait for additional code changes) labels Dec 13, 2021
@korenyoni korenyoni added patch A minor, backward compatible change and removed chore labels Dec 13, 2021
@korenyoni korenyoni merged commit 1df0af9 into master Dec 13, 2021
@korenyoni korenyoni deleted the chore/bump-dependency-versions branch December 13, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-lobur max-lobur max-lobur approved these changes

@Nuru Nuru Nuru left review comments

@jhosteny jhosteny Awaiting requested review from jhosteny jhosteny was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
no-release Do not create a new release (wait for additional code changes) patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@korenyoni @Nuru @max-lobur @cloudpossebot