-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Update auto-release
(release-drafter
) GHA workflow to latest distribution; fix Terratest
#202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion from build-harness.
korenyoni
added
the
no-release
Do not create a new release (wait for additional code changes)
label
Dec 13, 2021
korenyoni
requested review from
Gowiem and
Benbentwo
and removed request for
a team
December 13, 2021 11:41
/test all |
max-lobur
previously approved these changes
Dec 13, 2021
korenyoni
force-pushed
the
chore/update-auto-release-workflow
branch
from
December 13, 2021 12:21
82402f1
to
b910061
Compare
korenyoni
changed the title
Chore: Update
Chore: Update Dec 13, 2021
auto-release
(release-drafter
) GHA workflow to latest distributionauto-release
(release-drafter
) GHA workflow to latest distribution; fix Terratest
/test all |
…unique for each run.
korenyoni
force-pushed
the
chore/update-auto-release-workflow
branch
from
December 13, 2021 13:10
b910061
to
2cef324
Compare
/test all |
…posse/terraform-aws-cloudfront-s3-cdn into chore/update-auto-release-workflow
/test all |
max-lobur
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
🐛 An issue with the system
no-release
Do not create a new release (wait for additional code changes)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
auto-release
GHA workflow from https://github.com/cloudposse/build-harness allows merged PRs to be accumulated in a draft release when theno-release
label is used. This allows PRs to be consolidated rather than each given their own release — as renovatebot will cause a rippling series of module updates across all repositories that use this module, and all repositories that use those modules, etc.make github/init
, which will update all GHA-related files to the latest build-harness distribution. However, changing CODEOWNERS will require admin approval and this is a blocker.examples/complete
was creating IAM roles whose names did not make the use ofmodule.this.attributes
(which contains a random seed in each run). Also, the test timeout was not sufficiently long to complete all tests.references
no-release
label build-harness#296