Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update auto-release (release-drafter) GHA workflow to latest distribution; fix Terratest #202

Merged
merged 5 commits into from
Dec 13, 2021

Conversation

korenyoni
Copy link
Member

@korenyoni korenyoni commented Dec 13, 2021

what

  • Update auto-release (release-drafter) GHA workflow to latest distribution from build-harness.
  • Fix Terratest by ensuring IAM roles created by examples/complete are unique for each run (also increase test timeout).

why

  • The latest distribution of the auto-release GHA workflow from https://github.com/cloudposse/build-harness allows merged PRs to be accumulated in a draft release when the no-release label is used. This allows PRs to be consolidated rather than each given their own release — as renovatebot will cause a rippling series of module updates across all repositories that use this module, and all repositories that use those modules, etc.
  • This is a subset of make github/init, which will update all GHA-related files to the latest build-harness distribution. However, changing CODEOWNERS will require admin approval and this is a blocker.
  • Terratest was failing because examples/complete was creating IAM roles whose names did not make the use of module.this.attributes (which contains a random seed in each run). Also, the test timeout was not sufficiently long to complete all tests.

references

@korenyoni korenyoni added the no-release Do not create a new release (wait for additional code changes) label Dec 13, 2021
@korenyoni korenyoni requested review from a team as code owners December 13, 2021 11:41
@korenyoni korenyoni requested review from Gowiem and Benbentwo and removed request for a team December 13, 2021 11:41
@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni requested a review from max-lobur December 13, 2021 11:46
max-lobur
max-lobur previously approved these changes Dec 13, 2021
@korenyoni korenyoni requested a review from a team as a code owner December 13, 2021 12:19
@korenyoni korenyoni force-pushed the chore/update-auto-release-workflow branch from 82402f1 to b910061 Compare December 13, 2021 12:21
@korenyoni korenyoni added the bug 🐛 An issue with the system label Dec 13, 2021
@korenyoni korenyoni changed the title Chore: Update auto-release (release-drafter) GHA workflow to latest distribution Chore: Update auto-release (release-drafter) GHA workflow to latest distribution; fix Terratest Dec 13, 2021
@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni force-pushed the chore/update-auto-release-workflow branch from b910061 to 2cef324 Compare December 13, 2021 13:10
@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni requested a review from max-lobur December 13, 2021 13:15
…posse/terraform-aws-cloudfront-s3-cdn into chore/update-auto-release-workflow
@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni merged commit 5d66fcc into master Dec 13, 2021
@korenyoni korenyoni deleted the chore/update-auto-release-workflow branch December 13, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants