Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set viewer_certificate.ssl_support_method to a non-empty value #208

Merged
merged 2 commits into from
Jan 12, 2022
Merged

fix: set viewer_certificate.ssl_support_method to a non-empty value #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e604466
fix: set ssl_support_method to value
syphernl Jan 11, 2022
bb27c86
Updated README.md
actions-bot Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ In general, PRs are welcome. We follow the typical "fork-and-pull" Git workflow.

## Copyright

Copyright © 2017-2021 [Cloud Posse, LLC](https://cpco.io/copyright)
Copyright © 2017-2022 [Cloud Posse, LLC](https://cpco.io/copyright)



Expand Down
2 changes: 1 addition & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ resource "aws_cloudfront_distribution" "default" {

viewer_certificate {
acm_certificate_arn = var.acm_certificate_arn
ssl_support_method = local.use_default_acm_certificate ? "" : "sni-only"
ssl_support_method = "sni-only"
Copy link

@bridgecrew bridgecrew bot Jan 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW   Ensure CloudFront distribution has a strict security headers policy attached
    Resource: aws_cloudfront_distribution.default | ID: BC_AWS_NETWORKING_65

Copy link

@bridgecrew bridgecrew bot Jan 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW   Verify CloudFront Distribution Viewer Certificate is using TLS v1.2
    Resource: aws_cloudfront_distribution.default | ID: BC_AWS_NETWORKING_63

How to Fix

resource "aws_cloudfront_distribution" "pass" {
...

  viewer_certificate {
    cloudfront_default_certificate = false
    minimum_protocol_version = "TLSv1.2_2018"
  }
}

Description

This policy identifies AWS CloudFront web distributions which are configured with TLS versions for HTTPS communication between viewers and CloudFront. As a best practice, use TLSv1.1_2016 or later as the minimum protocol version in your CloudFront distribution security policies

Dependent Resources



Calculating...

🎉   Fixed by commit bb27c86 - Updated README.md

minimum_protocol_version = local.minimum_protocol_version
cloudfront_default_certificate = local.use_default_acm_certificate
}
Expand Down