fix: set viewer_certificate.ssl_support_method to a non-empty value #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphernl
requested review from
Gowiem and
Benbentwo
and removed request for
a team
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
| @@ -439,7 +439,7 @@ resource "aws_cloudfront_distribution" "default" { | |||
|
|
|||
| viewer_certificate { | |||
| acm_certificate_arn = var.acm_certificate_arn | |||
| ssl_support_method = local.use_default_acm_certificate ? "" : "sni-only" | |||
| ssl_support_method = "sni-only" | |||
There was a problem hiding this comment.
Ensure CloudFront distribution has a strict security headers policy attached
Resource: aws_cloudfront_distribution.default | ID: BC_AWS_NETWORKING_65
| @@ -439,7 +439,7 @@ resource "aws_cloudfront_distribution" "default" { | |||
|
|
|||
| viewer_certificate { | |||
| acm_certificate_arn = var.acm_certificate_arn | |||
| ssl_support_method = local.use_default_acm_certificate ? "" : "sni-only" | |||
| ssl_support_method = "sni-only" | |||
There was a problem hiding this comment.
Verify CloudFront Distribution Viewer Certificate is using TLS v1.2
Resource: aws_cloudfront_distribution.default | ID: BC_AWS_NETWORKING_63
How to Fix
resource "aws_cloudfront_distribution" "pass" {
...
viewer_certificate {
cloudfront_default_certificate = false
minimum_protocol_version = "TLSv1.2_2018"
}
}Description
This policy identifies AWS CloudFront web distributions which are configured with TLS versions for HTTPS communication between viewers and CloudFront. As a best practice, use TLSv1.1_2016 or later as the minimum protocol version in your CloudFront distribution security policiesDependent Resources
Calculating...
🎉 Fixed by commit bb27c86 - Updated README.md
Closed
|
/rebuild-readme |
korenyoni
previously approved these changes
Jan 12, 2022
korenyoni
added
the
no-release
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_NETWORKING_63 Fixed /main.tf aws_cloudfront_distribution.default
|
/test all |
|
Going to merge with BC "errors" unresolved because I have them fixed in #209 |
korenyoni
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
viewer_certificate.ssl_support_methodto a non-empty valuewhy
viewer_certificate.ssl_support_methodis being validated on plan-time and can no longer be an empty string but must besni-onlyorvip(of which the latter incurs costs)references