Feat: Add Support for S3 Object Ownership Controls #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korenyoni
requested review from
dylanbannon and
brcnblc
and removed request for
a team
korenyoni
added
the
no-release
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_NETWORKING_65 Fixed /main.tf aws_cloudfront_distribution.default BC_AWS_NETWORKING_63 Fixed /main.tf aws_cloudfront_distribution.default
|
/test all |
max-lobur
previously approved these changes
Jan 12, 2022
|
Breaking because of new plan-time validation in https://github.com/hashicorp/terraform-provider-aws/releases/tag/v3.71.0 EDIT: fixed by #208 |
mergify
bot
dismissed
max-lobur’s stale review
This Pull Request has been updated, so we're dismissing all reviews.
|
/test all |
max-lobur
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
S3 object ownership controls should be configurable for the origin bucket behind the CloudFront distribution. If the origin bucket is used within CI pipelines, cross-account writes to the bucket will result in the object being owned by that account. This can result in 403's when attempting to access content in the CF distribution, unless the S3 object ownership setting is set to
BucketOwnerEnforced.The new S3 object ownership variable has as a default value that has the same effect if the new
s3_bucket_ownership_controlswere not to exist at all. Thus, this is a backwards-compatible release.references