Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle viewer_certificate.ssl_support_method with CF default certificate #213

Merged
merged 3 commits into from
Jan 27, 2022
Merged

fix: handle viewer_certificate.ssl_support_method with CF default certificate #213

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67732c8
fix: handle viewer_certificate.ssl_support_method with CF certificates
syphernl Jan 25, 2022
994a904
Auto Format
cloudpossebot Jan 25, 2022
f71af4b
Merge branch 'master' into fix/sni_ref
korenyoni Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ resource "aws_cloudfront_distribution" "default" {

viewer_certificate {
acm_certificate_arn = var.acm_certificate_arn
ssl_support_method = "sni-only"
ssl_support_method = local.use_default_acm_certificate ? null : "sni-only"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#208

Does null behave differently than "" ? in terms of how the provider validates this field?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately yes. Providing "" results in it complaining you need to provide one of the two valid values. However sni-only causes issues with CF-issued certificates which works fine with null.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right I believe because it's an optional value it'll be fine, but "" is subject to the validation method https://github.com/hashicorp/terraform-provider-aws/blob/c47375e5482213883df51795322e2e2b55bc9348/internal/service/cloudfront/distribution.go#L694

minimum_protocol_version = local.minimum_protocol_version
cloudfront_default_certificate = local.use_default_acm_certificate
}
Expand Down