Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions.tf #218

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Update versions.tf #218

merged 2 commits into from
Feb 15, 2022

Conversation

rusowyler
Copy link
Contributor

@rusowyler rusowyler commented Feb 15, 2022

what

  • Restrict AWS provider version

why

  • >= 3.64 because response_headers_policy_id first appeared on version: 3.64.0 (November 04, 2021)
  • < 4.0.0 many breaking changes affect this module.

references

response_headers_policy_id first appeared on version: 3.64.0 (November 04, 2021)
As of version 4.0.0 (February 10, 2022), many breaking changes affect this module.

We need to restrict it until rewritten.
@rusowyler rusowyler requested review from a team as code owners February 15, 2022 18:48
@rusowyler rusowyler requested review from dotCipher and milldr and removed request for a team February 15, 2022 18:48
@Gowiem
Copy link
Member

Gowiem commented Feb 15, 2022

/test all

@Gowiem Gowiem self-assigned this Feb 15, 2022
@Gowiem Gowiem added the patch A minor, backward compatible change label Feb 15, 2022
@Gowiem Gowiem merged commit 0891c7f into cloudposse:master Feb 15, 2022
@Nuru
Copy link
Contributor

Nuru commented Feb 18, 2022

@Gowiem We do not allow provider pinning except for >=. This PR should not have passed automated testing (I'm looking into that) and should not have been approved.

Our policy is that if a new provider version breaks an existing module, users of that module should put the provider pin e.g. < 4.0 in their component or use the .terraform.lock.hcl file. When the module is upgraded to work with the new provider, then it can be pinned, in this case >= 4.0.0.

@Nuru Nuru mentioned this pull request Feb 18, 2022
1 task
@Gowiem
Copy link
Member

Gowiem commented Feb 21, 2022

@Nuru gotcha and apologies, I didn't know about that. Let's discuss in Slack here if you don't mind.

@apanzerj
Copy link

Hi!

What's the outcome from that slack discussion?

Is there plans to upgrade to 4.0?

@diestrin
Copy link

It doesn't let me run it with the v4 provider still :(

nitrocode added a commit that referenced this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants