Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow AWS provider version >= 4.9.0 #236

Merged
merged 4 commits into from
Aug 16, 2022
Merged

Allow AWS provider version >= 4.9.0 #236

merged 4 commits into from
Aug 16, 2022

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Aug 15, 2022 •
edited by Nuru
Loading

what

  • Allow AWS provider version >= 4.9.0

references

  • Version 4.0.0 had breaking changes, so this module had pinned AWS provider < 4.0. Breaking changes were replaced with deprecation warnings in v4.9.0, so we can now allow later versions.

@nitrocode nitrocode requested review from a team as code owners August 15, 2022 14:45
@nitrocode nitrocode requested review from Gowiem and woz5999 and removed request for a team August 15, 2022 14:45
@Nuru Nuru changed the title Revert "Update versions.tf (#218)" Allow AWS provider version >= 4.9.0 Aug 16, 2022
@Nuru Nuru added the patch A minor, backward compatible change label Aug 16, 2022
@Nuru
Copy link
Contributor

Nuru commented Aug 16, 2022

/test all

Nuru
Nuru approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@Nuru Nuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to more appropriate version constraint

@Nuru Nuru merged commit 2802ae3 into master Aug 16, 2022
@Nuru Nuru deleted the revert-0.82.3 branch August 16, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem was automatically assigned from cloudposse/contributors

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitrocode @Nuru @cloudpossebot