Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for aws provider 5.0 #280

Closed
wants to merge 8 commits into from
Closed

feat: Add support for aws provider 5.0 #280

wants to merge 8 commits into from

Conversation

MaxymVlasov
Copy link

@MaxymVlasov MaxymVlasov commented May 29, 2023 •
edited
Loading

what

why

That fields/modules have deprecated stuff, that was removed in 5.0

references

Also, includes #282 as @aknysh suggest

@MaxymVlasov MaxymVlasov requested review from a team as code owners May 29, 2023 14:07
@MaxymVlasov MaxymVlasov requested review from Gowiem and joe-niland May 29, 2023 14:07
@aknysh
Copy link
Member

aknysh commented May 29, 2023

@MaxymVlasov please run

make init
make github/init
make readme

and commit the changes

@aknysh
Copy link
Member

aknysh commented May 29, 2023

/terratest

@aknysh
Copy link
Member

aknysh commented May 29, 2023

@MaxymVlasov something is still not up to date https://github.com/cloudposse/actions/actions/runs/5113055710/jobs/9191823420

@aknysh
Copy link
Member

aknysh commented May 29, 2023

/terratest

aknysh
aknysh requested changes May 29, 2023
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some terraform modules need to be updated to support the aws provider v5

@mschfh
Copy link
Contributor

mschfh commented May 30, 2023

looks like test failures are due to AWS changes affecting new resources:

Error: creating CloudFront Distribution: InvalidArgument: The S3 bucket that you specified for CloudFront logs does not enable ACL access: eg-test-cloudfront-s3-cdn-97365-logs.s3.amazonaws.com

https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/

InvalidParameterValueException: The runtime parameter of nodejs12.x is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs18.x) while creating or updating functions

https://aws.amazon.com/blogs/developer/announcing-the-end-of-support-for-node-js-12-x-in-the-aws-sdk-for-javascript-v3/
https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html#runtime-support-policy

@sebnapo
Copy link

sebnapo commented Jun 1, 2023

You will need something like this to fix the problems regarding S3 :
main...hdurix:terraform-aws-cloudfront-s3-cdn:master

@MaxymVlasov
Copy link
Author

Good catch @sebnapo
So, depends on #282

/cc @aknysh

@MaxymVlasov MaxymVlasov requested a review from aknysh June 1, 2023 18:09
aknysh
aknysh reviewed Jul 14, 2023
View reviewed changes
main.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jul 14, 2023
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaxymVlasov please update the module versions to the latest

@MaxymVlasov MaxymVlasov requested a review from aknysh July 14, 2023 14:17
@aknysh
Copy link
Member

aknysh commented Jul 14, 2023

/terratest

@aknysh
Copy link
Member

aknysh commented Jul 14, 2023

/terratest

@MaxymVlasov
Disable additional_custom_origins_enabled to temporary avoid
a3d2bf7 
compatibility issues. Guided by Andriy Knysh
@aknysh
Copy link
Member

aknysh commented Jul 14, 2023

/terratest

@MaxymVlasov
Copy link
Author

Was resolved by #284

@MaxymVlasov MaxymVlasov closed this Sep 5, 2023
@MaxymVlasov MaxymVlasov deleted the patch branch September 5, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MaxymVlasov @aknysh @mschfh @sebnapo @hdurix