Support AWS Provider V5 #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-lobur
added
the
no-release
max-lobur
added
major
|
/terratest |
|
/terratest |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
/terratest |
|
/terratest |
|
/terratest |
|
/terratest |
|
/terratest |
|
/terratest |
|
/terratest |
|
/terratest |
|
/terratest |
|
/terratest |
zdmytriv
approved these changes
Jul 25, 2023
This was referenced Jul 25, 2023
abeluck
pushed a commit
to abeluck/terraform-aws-cloudfront-s3-cdn
that referenced
this pull request
Aug 11, 2023
* Support AWS Provider V5 * Update versions.tf * Update versions.tf * Update versions.tf * Support AWS Provider V5 * bump provider * Support AWS Provider V5 * Support AWS Provider V5 * Support AWS Provider V5 * Support AWS Provider V5 * upd * upd * upd * upd * upd * upd * upd * upd * upd * upd * upd * upd * upd * Add policy * use ACL for logging s3-bucket access * make readme * Removed unused locals, use updated bucket acl pattern, enable logging by local * allow public policy for test bucket * tf fmt * set BucketOwnerEnforced * set acl with string, not grant * set logs ownership to ObjectWriter * set s3_object_ownership for test buckets * set logs bucket to BucketOwnerPreferred * Set bucket-owner-full-control * reset to grant * Update main.tf Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * set log-delivery-write for test bucekts * set ownership on test bucket * set BucketOwnerPreferred with grant list for test buckets * reset tests, set ownership to BucketOwnerPreferred * setting s3_object_ownership * dependency for bucket settings before cdn * Update examples/complete/main.tf Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * dependency for tweaks * added more wait ons for bucket settings * added more wait ons for bucket settings * set ownership on test bucket, set acl null of s3 * set BucketOwnerEnforced * set grants * set grants * Set policy after bucket settings * Set block_origin_public_access_enabled * revert s3-origins test * set BucketOwnerEnforced * sleep for eventual consistency * Set acl for s3-origin tests * replace s3-website module with s3-bucket for tests * corrected bucket name input * corrected bucket name input * bridgecrew issues resolved --------- Co-authored-by: milldr <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Support AWS Provider V5
Linter fixes
why
Maintenance
references
https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.0.0