Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Public Bucket Policy #288

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Allow Public Bucket Policy #288

merged 2 commits into from
Jul 27, 2023

Conversation

milldr
Copy link
Member

@milldr milldr commented Jul 26, 2023

what

why

  • Only restrict public access on the bucket if we're blocking public access. Otherwise Cloudfront will not be able to access the bucket

references

@milldr milldr requested review from a team as code owners July 26, 2023 23:33
@milldr milldr requested review from srhopkins and joe-niland July 26, 2023 23:33
@milldr
Copy link
Member Author

milldr commented Jul 26, 2023

/terratest

@milldr
Copy link
Member Author

milldr commented Jul 27, 2023

/terratest

1 similar comment
@aknysh
Copy link
Member

aknysh commented Jul 27, 2023

/terratest

@milldr milldr enabled auto-merge (squash) July 27, 2023 00:23
@milldr milldr merged commit 1dc4708 into main Jul 27, 2023
@milldr milldr deleted the public-bucket-access branch July 27, 2023 01:07
@milldr milldr mentioned this pull request Jul 27, 2023
Merged
abeluck pushed a commit to abeluck/terraform-aws-cloudfront-s3-cdn that referenced this pull request Aug 11, 2023
@milldr @aknysh @abeluck
allow public accessible policy (cloudposse#288)
f9b5c1c 
Co-authored-by: Andriy Knysh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@srhopkins srhopkins Awaiting requested review from srhopkins srhopkins is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milldr @aknysh