Skip to content

v0.67.0

Compare
Choose a tag to compare
@cloudpossebot cloudpossebot released this 17 May 13:18
112a53d
Fix: Deployment Principal ARNs @korenyoni (#164)

what

  • Add test for deployment_principal_arns
  • Fix order of nested functions when rendering bucket policy for deployment_principal_arns — otherwise an error occurs when comparing types.
  • Fix snippet: all prefixes must begin in forward slash or otherwise the bucket policy JSON will be invalid.
  • Fix snippet passing incorrect variable name.
  • Programatically fix missing leading forward slash for prefixes in Bucket Policy

(misc)

  • Fix typo in tfvars fixtures in example.
  • Add enablement toggles to all resources in example
  • Fix minimum_protocol_version being passed when it won't be honored by AWS i.e. when s3_access_log_bucket_name is true as a result of acm_certificate_arn being unset.
  • Fix default for s3_access_log_bucket_name — it is supposed to be empty and there is a check for its length in locals{} that assumes it is empty by default, but it is not empty by default.

why

  • deployment_principal_arns was not working and examples/complete was not testing for it

references