Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream spa-s3-cloudfront #778

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Upstream spa-s3-cloudfront #778

merged 1 commit into from
Jul 26, 2023

Conversation

milldr
Copy link
Member

@milldr milldr commented Jul 25, 2023

what

  • Upstream changes to spa-s3-cloudfront

why

  • Updated the included modules to support Terraform v5
  • Handle disabled WAF from remote-state

references

@milldr milldr requested review from a team as code owners July 25, 2023 22:28
@@ -54,7 +54,7 @@ locals {
# Create an ACM and explicitly set it to us-east-1 (requirement of CloudFront)
module "acm_request_certificate" {
source = "cloudposse/acm-request-certificate/aws"
version = "0.17.0"
version = "0.16.3"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milldr milldr merged commit c72de34 into main Jul 26, 2023
@milldr milldr deleted the upstream-spa-cdn branch July 26, 2023 16:20
goruha pushed a commit to cloudposse-terraform-components/aws-spa-s3-cloudfront that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants