Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change policy to source_policy_documents #39

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Change policy to source_policy_documents #39

merged 2 commits into from
Aug 7, 2023

Conversation

johncblandii
Copy link
Contributor

what

  • Use source_policy_documents instead of policy

why

  • policy is combined with source_policy_documents upstream, but there is a ref to var.source_policy_documents and not the combined local.source_policy_documents so using only policy is not working
  • policy is also deprecated so usage needs to be removed

references

@johncblandii johncblandii requested review from a team as code owners August 3, 2023 20:17
@johncblandii johncblandii mentioned this pull request Aug 3, 2023
Merged
mcalhoun
mcalhoun previously approved these changes Aug 7, 2023
View reviewed changes
@mcalhoun
Copy link
Member

mcalhoun commented Aug 7, 2023

/terratest

@mcalhoun mcalhoun added the patch A minor, backward compatible change label Aug 7, 2023
@mcalhoun mcalhoun self-requested a review August 7, 2023 18:27
mcalhoun
mcalhoun approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@mcalhoun mcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcalhoun mcalhoun merged commit 0b1ed0c into main Aug 7, 2023
@mcalhoun mcalhoun deleted the feat/source-policy-fixes branch August 7, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcalhoun mcalhoun mcalhoun approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@korenyoni korenyoni Awaiting requested review from korenyoni korenyoni is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johncblandii @mcalhoun