Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix source_policy_documents combined with var.policy being ignored #201

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Fix source_policy_documents combined with var.policy being ignored #201

merged 2 commits into from
Aug 3, 2023

Conversation

johncblandii
Copy link
Contributor

what

  • Changed var.source_policy_documents to local.source_policy_documents so var.policy usage was still supported

why

  • The ternary check uses var,source_policy_documents so var.policy being combined with var.source_policy_documents into local.source_policy_documents does not provide true for the ternary to execute

references

@johncblandii johncblandii requested review from a team as code owners August 3, 2023 20:20
mcalhoun
mcalhoun previously approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@mcalhoun mcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcalhoun mcalhoun added the patch A minor, backward compatible change label Aug 3, 2023
@mcalhoun mcalhoun self-requested a review August 3, 2023 20:47
@mcalhoun mcalhoun enabled auto-merge (squash) August 3, 2023 20:48
@mcalhoun
Copy link
Member

mcalhoun commented Aug 3, 2023

/terratest

@mcalhoun mcalhoun merged commit d7a4943 into main Aug 3, 2023
@mcalhoun mcalhoun deleted the feat/source_policy_documents-fix branch August 3, 2023 21:39
@Nuru
Copy link
Contributor

Nuru commented Aug 25, 2023

Unfortunately, this makes count unknown at plan time in certain situations. In general, you cannot use the output of compact() in count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcalhoun mcalhoun mcalhoun approved these changes

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johncblandii @mcalhoun @Nuru