Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use minimum versions for provider pinning #19

Closed
wants to merge 1 commit into from

Conversation

woz5999
Copy link
Contributor

@woz5999 woz5999 commented Sep 2, 2020

what

set minimum versions for providers without pinning to a specific major version

why

the current method makes it very difficult to maintain or upgrade consistent provider versions within a project

references

https://www.terraform.io/docs/configuration/provider-requirements.html#best-practices-for-provider-versions
cloudposse/terraform-aws-iam-system-user#33

@woz5999 woz5999 requested a review from a team as a code owner September 2, 2020 02:22
@woz5999 woz5999 requested review from htplbc and joe-niland September 2, 2020 02:22
@woz5999 woz5999 changed the title pin minimum provider versions use minimum versions for provider pinning Sep 2, 2020
@@ -9,7 +9,7 @@ data "aws_iam_policy_document" "default" {
}

module "s3_user" {
source = "git::https://github.com/cloudposse/terraform-aws-iam-system-user.git?ref=tags/0.14.0"
source = "git::https://github.com/cloudposse/terraform-aws-iam-system-user.git?ref=tags/0.16.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is speculative based on the latest version of the module and cloudposse/terraform-aws-iam-system-user#33

@woz5999
Copy link
Contributor Author

woz5999 commented Sep 3, 2020

@aknysh

@woz5999 woz5999 closed this Sep 3, 2020
@woz5999
Copy link
Contributor Author

woz5999 commented Sep 3, 2020

nvm this was handled in #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant