Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open it up to v3 of the aws provider #20

Merged
merged 4 commits into from
Sep 3, 2020
Merged

open it up to v3 of the aws provider #20

merged 4 commits into from
Sep 3, 2020

Conversation

jurgenweber
Copy link
Contributor

as per all the others; cloudposse/terraform-aws-s3-bucket#47

@jurgenweber jurgenweber requested a review from a team as a code owner September 3, 2020 03:40
@jurgenweber jurgenweber requested review from htplbc and aknysh September 3, 2020 03:40
aknysh
aknysh reviewed Sep 3, 2020
View reviewed changes
versions.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Sep 3, 2020
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jurgenweber please see comments

aknysh
aknysh reviewed Sep 3, 2020
View reviewed changes
versions.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Sep 3, 2020
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@jurgenweber jurgenweber requested a review from aknysh September 3, 2020 04:12
@aknysh
Copy link
Member

aknysh commented Sep 3, 2020

/test all

@aknysh
Copy link
Member

aknysh commented Sep 3, 2020

/rebuild-readme

@aknysh
Copy link
Member

aknysh commented Sep 3, 2020

/test all

aknysh
aknysh approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jurgenweber

@aknysh aknysh merged commit 17b6655 into cloudposse:master Sep 3, 2020
@woz5999 woz5999 mentioned this pull request Sep 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@htplbc htplbc Awaiting requested review from htplbc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jurgenweber @aknysh @actions-bot