Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ses smpt password to ssm, add ssm base path option #61

Conversation

sebastianmacarescu
Copy link

what

  • Add option to change the SSM base path under which credentials are stored
  • Store ses_smtp_password_v4 in SSM

why

  • Even if the IAM users are global per account often times there is a need to separeate them per environment (dev, staging). By adding the ssm_base_path parameter we can have a better SSM hierarchy. Example: /dev/system_user/tc-dev-s3 and /staging/system_user/tc-staging-ses
  • Also having the ses_smtp_password_v4 stored in SSM will allow better integration with CI systems when deploying applications (rather than having a script to generate the password or read the terraform state)

references

@sebastianmacarescu sebastianmacarescu requested review from a team as code owners December 4, 2021 18:28
@sebastianmacarescu sebastianmacarescu requested review from Makeshift and brcnblc and removed request for a team December 4, 2021 18:28
@sebastianmacarescu
Copy link
Author

Can we get this merged?

@Gowiem
Copy link
Member

Gowiem commented Apr 20, 2022

/test all

@Gowiem Gowiem self-requested a review April 20, 2022 15:52
@Gowiem
Copy link
Member

Gowiem commented Apr 20, 2022

@sebastianmacarescu can you run the following locally and then commit and push?

make init && make readme

@sebastianmacarescu
Copy link
Author

@Gowiem I can't run that since I'm on windows. Let me know if I can help with anything else.

@Gowiem
Copy link
Member

Gowiem commented May 3, 2022

@sebastianmacarescu I had to pull your changes and fix the readme on my end since you couldn't. Reopened your changes as #61. We'll get that merged shortly.

@Nuru Nuru closed this in #65 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ses_smtp_password_v4 to SSM
3 participants