-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ses smpt password to ssm, add ssm base path option #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erraform-aws-iam-system-user into feature/improve-ssm
Gowiem
requested review from
dotCipher and
nitrocode
and removed request for
a team
May 3, 2022 23:39
/test all |
This pull request is now in conflict. Could you fix it @Gowiem? 🙏 |
nitrocode
reviewed
May 3, 2022
@Gowiem conflict |
@nitrocode have you seen those auto-readme conflicts before? Not sure what is up there... I believe I want to accept all the incoming changes, but wanted to get another set of eyes before I undo some work if I'm wrong. |
…em-user into feature/improve-ssm
Gowiem
force-pushed
the
feature/improve-ssm
branch
from
May 4, 2022 17:01
0a1252f
to
7aad31b
Compare
/test all |
/test all |
Nuru
added
the
no-release
Do not create a new release (wait for additional code changes)
label
Sep 2, 2022
Nuru
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
ssm_base_path
parameter we can have a better SSM hierarchy. Example:/dev/system_user/tc-dev-s3
and/staging/system_user/tc-staging-ses
ses_smtp_password_v4
stored in SSM will allow better integration with CI systems when deploying applications (rather than having a script to generate the password or read the terraform state)references