Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ses smpt password to ssm, add ssm base path option #65

Merged
merged 8 commits into from
Sep 2, 2022

Conversation

Gowiem
Copy link
Member

@Gowiem Gowiem commented May 3, 2022

what

  • Add option to change the SSM base path under which credentials are stored
  • Store ses_smtp_password_v4 in SSM

why

  • Even if the IAM users are global per account often times there is a need to separeate them per environment (dev, staging). By adding the ssm_base_path parameter we can have a better SSM hierarchy. Example: /dev/system_user/tc-dev-s3 and /staging/system_user/tc-staging-ses
  • Also having the ses_smtp_password_v4 stored in SSM will allow better integration with CI systems when deploying applications (rather than having a script to generate the password or read the terraform state)

references

@Gowiem Gowiem self-assigned this May 3, 2022
@Gowiem Gowiem requested review from a team as code owners May 3, 2022 23:39
@Gowiem Gowiem requested review from dotCipher and nitrocode and removed request for a team May 3, 2022 23:39
@Gowiem
Copy link
Member Author

Gowiem commented May 3, 2022

/test all

@mergify
Copy link

mergify bot commented May 3, 2022

This pull request is now in conflict. Could you fix it @Gowiem? 🙏

main.tf Show resolved Hide resolved
@nitrocode
Copy link
Member

@Gowiem conflict

@Gowiem
Copy link
Member Author

Gowiem commented May 3, 2022

@nitrocode have you seen those auto-readme conflicts before? Not sure what is up there... I believe I want to accept all the incoming changes, but wanted to get another set of eyes before I undo some work if I'm wrong.

@Gowiem Gowiem force-pushed the feature/improve-ssm branch from 0a1252f to 7aad31b Compare May 4, 2022 17:01
@Gowiem
Copy link
Member Author

Gowiem commented May 4, 2022

/test all

@Gowiem
Copy link
Member Author

Gowiem commented May 4, 2022

/test all

@Gowiem Gowiem requested a review from nitrocode May 4, 2022 18:31
@Nuru Nuru added the no-release Do not create a new release (wait for additional code changes) label Sep 2, 2022
@Nuru Nuru enabled auto-merge (squash) September 2, 2022 22:54
@Nuru Nuru self-requested a review September 2, 2022 22:54
@Nuru Nuru merged commit 0e9171e into master Sep 2, 2022
@Nuru Nuru deleted the feature/improve-ssm branch September 2, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ses_smtp_password_v4 to SSM
5 participants