Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump aws provider to v4 #5

Closed
wants to merge 4 commits into from
Closed

Bump aws provider to v4 #5

wants to merge 4 commits into from

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Feb 10, 2022 •
edited
Loading

Depends on PR cloudposse/terraform-aws-s3-bucket#131

what

  • Bump s3 bucket module to use v4 provider
  • Bump aws provider to v4

why

  • Team decision has been to not pin modules to major versions so better to role forward
  • Many errors with v4 in cloudposse/s3-bucket module
│ Error: Unsupported attribute
│ 
│   on .terraform-mdev/modules/mwaa_environment.mwaa_s3_bucket/main.tf line 166, in resource "aws_s3_bucket" "default":
│  166:         for_each = local.s3_replication_rules == null ? [] : local.s3_replication_rules
│ 
│ This object does not have an attribute named "s3_replication_rules".

references

@nitrocode nitrocode requested review from a team as code owners February 10, 2022 19:21
@nitrocode nitrocode requested review from adamcrews and leb4r February 10, 2022 19:21
@nitrocode nitrocode added the patch A minor, backward compatible change label Feb 10, 2022
@korenyoni
Copy link
Member

/test all

korenyoni
korenyoni previously approved these changes Feb 10, 2022
View reviewed changes
@nitrocode
Copy link
Member Author

/test all

htplbc
htplbc approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@htplbc htplbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

@nitrocode nitrocode marked this pull request as draft February 10, 2022 20:35
@nitrocode nitrocode removed the patch A minor, backward compatible change label Feb 10, 2022
@nitrocode nitrocode changed the title Set pin to v3 for now Bump aws provider to v4 Feb 10, 2022
@mergify
Copy link

mergify bot commented Mar 14, 2022

This pull request is now in conflict. Could you fix it @nitrocode? 🙏

@htplbc htplbc closed this Mar 24, 2022
@htplbc
Copy link
Contributor

htplbc commented Mar 24, 2022

This has been moved to v4 already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korenyoni korenyoni korenyoni approved these changes

@htplbc htplbc htplbc approved these changes

@adamcrews adamcrews Awaiting requested review from adamcrews adamcrews was automatically assigned from cloudposse/contributors

@leb4r leb4r Awaiting requested review from leb4r leb4r was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nitrocode @korenyoni @htplbc @cloudpossebot