Upgrade to v4 aws provider #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korenyoni
previously approved these changes
Feb 10, 2022
|
/test all |
|
/test all |
korenyoni
previously approved these changes
Feb 10, 2022
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_GENERAL_72 Added /main.tf aws_s3_bucket.default BC_AWS_NETWORKING_52 Added /main.tf aws_s3_bucket.default
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_NETWORKING_52 Added /main.tf aws_s3_bucket.default BC_AWS_GENERAL_72 Fixed /main.tf module.s3_bucket_replication_target.aws_s3_bucket.default BC_AWS_GENERAL_72 Fixed /main.tf module.s3_bucket_replication_target_extra.aws_s3_bucket.default BC_AWS_GENERAL_72 Fixed /main.tf module.s3_bucket.aws_s3_bucket.default
|
|
||
| dynamic "versioning" { | ||
| for_each = var.versioning_enabled ? [true] : [] | ||
| count = local.enabled ? 1 : 0 |
There was a problem hiding this comment.
Ensure S3 bucket has cross-region replication enabled
Resource: module.s3_bucket_replication_target.aws_s3_bucket.default | ID: BC_AWS_GENERAL_72
How to Fix
resource "aws_s3_bucket" "test" {
...
+ replication_configuration {
+ role = aws_iam_role.replication.arn
+ rules {
+ id = "foobar"
+ prefix = "foo"
+ status = "Enabled"
+
+ destination {
+ bucket = aws_s3_bucket.destination.arn
+ storage_class = "STANDARD"
+ }
+ }
+ }
}Description
Cross-region replication enables automatic, asynchronous copying of objects across S3 buckets. By default, replication supports copying new S3 objects after it is enabled. It is also possible to use replication to copy existing objects and clone them to a different bucket, but in order to do so, you must contact AWS Support.Dependent Resources
Calculating...
🎉 Fixed by commit 492c82b - Make backwards compatible
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_GENERAL_72 Fixed /main.tf module.s3_bucket_replication_target_extra.aws_s3_bucket.default BC_AWS_GENERAL_72 Fixed /main.tf module.s3_bucket_replication_target.aws_s3_bucket.default BC_AWS_GENERAL_72 Fixed /main.tf module.s3_bucket.aws_s3_bucket.default
|
|
||
| dynamic "versioning" { | ||
| for_each = var.versioning_enabled ? [true] : [] | ||
| count = local.enabled ? 1 : 0 |
There was a problem hiding this comment.
Ensure S3 bucket has cross-region replication enabled
Resource: module.s3_bucket.aws_s3_bucket.default | ID: BC_AWS_GENERAL_72
How to Fix
resource "aws_s3_bucket" "test" {
...
+ replication_configuration {
+ role = aws_iam_role.replication.arn
+ rules {
+ id = "foobar"
+ prefix = "foo"
+ status = "Enabled"
+
+ destination {
+ bucket = aws_s3_bucket.destination.arn
+ storage_class = "STANDARD"
+ }
+ }
+ }
}Description
Cross-region replication enables automatic, asynchronous copying of objects across S3 buckets. By default, replication supports copying new S3 objects after it is enabled. It is also possible to use replication to copy existing objects and clone them to a different bucket, but in order to do so, you must contact AWS Support.🎉 Fixed by commit 550e49b - lifecycle filter must be static, abort... must by dynamic.
|
|
||
| dynamic "versioning" { | ||
| for_each = var.versioning_enabled ? [true] : [] | ||
| count = local.enabled ? 1 : 0 |
There was a problem hiding this comment.
Ensure S3 bucket has cross-region replication enabled
Resource: module.s3_bucket_replication_target_extra.aws_s3_bucket.default | ID: BC_AWS_GENERAL_72
How to Fix
resource "aws_s3_bucket" "test" {
...
+ replication_configuration {
+ role = aws_iam_role.replication.arn
+ rules {
+ id = "foobar"
+ prefix = "foo"
+ status = "Enabled"
+
+ destination {
+ bucket = aws_s3_bucket.destination.arn
+ storage_class = "STANDARD"
+ }
+ }
+ }
}Description
Cross-region replication enables automatic, asynchronous copying of objects across S3 buckets. By default, replication supports copying new S3 objects after it is enabled. It is also possible to use replication to copy existing objects and clone them to a different bucket, but in order to do so, you must contact AWS Support.🎉 Fixed by commit 550e49b - lifecycle filter must be static, abort... must by dynamic.
|
|
||
| dynamic "versioning" { | ||
| for_each = var.versioning_enabled ? [true] : [] | ||
| count = local.enabled ? 1 : 0 |
There was a problem hiding this comment.
Ensure S3 bucket has cross-region replication enabled
Resource: module.s3_bucket_replication_target.aws_s3_bucket.default | ID: BC_AWS_GENERAL_72
How to Fix
resource "aws_s3_bucket" "test" {
...
+ replication_configuration {
+ role = aws_iam_role.replication.arn
+ rules {
+ id = "foobar"
+ prefix = "foo"
+ status = "Enabled"
+
+ destination {
+ bucket = aws_s3_bucket.destination.arn
+ storage_class = "STANDARD"
+ }
+ }
+ }
}Description
Cross-region replication enables automatic, asynchronous copying of objects across S3 buckets. By default, replication supports copying new S3 objects after it is enabled. It is also possible to use replication to copy existing objects and clone them to a different bucket, but in order to do so, you must contact AWS Support.🎉 Fixed by commit 550e49b - lifecycle filter must be static, abort... must by dynamic.
|
/test all |
nitrocode
commented
Feb 21, 2022
| @@ -1,10 +1,10 @@ | |||
| terraform { | |||
| required_version = ">= 0.13.0" | |||
| required_version = ">= 1.0" | |||
There was a problem hiding this comment.
do we have to move this pin to be greater than 1.0? I believe we only need to worry about the aws provider
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_GENERAL_72 Fixed /main.tf module.s3_bucket_replication_target_extra.aws_s3_bucket.default BC_AWS_GENERAL_72 Fixed /main.tf module.s3_bucket_replication_target.aws_s3_bucket.default BC_AWS_GENERAL_72 Fixed /main.tf module.s3_bucket.aws_s3_bucket.default
|
/test all |
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_GENERAL_72 Fixed /main.tf module.s3_bucket_replication_target_extra.aws_s3_bucket.default BC_AWS_GENERAL_72 Fixed /main.tf module.s3_bucket_replication_target.aws_s3_bucket.default BC_AWS_GENERAL_72 Fixed /main.tf module.s3_bucket.aws_s3_bucket.default BC_AWS_GENERAL_72 Fixed /main.tf aws_s3_bucket.default
aknysh
reviewed
Feb 22, 2022
aknysh
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
policyin favor ofsource_policy_documents, closes Fix: Uselist(string)forvar.policy#124grantsin favor ofacl_grantslifecycle_rulesin favor oflifecycle_configuration_ruleswebsite_inputsis unavailable in the tests.cors_rule_inputsis available but unused.grant.permissionsinto separategrant.permissionblocks ?why
>= 4.2.0because of relevant bug fixes needed by this modulereferences
notes
grantsis now deprecated, but still supported. New input replacing it isacl_grants. The only difference is thatgrantstakes a list ofpermissionsandacl_grantstakes a singlepermission. The only reason we are makinggrantsdeprecated is so that our inputs track the AWS resource inputs.lifecycle_rulesis now deprecated but still supported, replaced withlifecycle_configuration_rules, which is identical except thatlifecycle_configuration_ruleshas anidfor each rule, which is now required by the AWS resource (doc). This module supplies anidforlifecycle_rules.aws_s3_bucket_lifecycle_configurationrequires a staticrules.filterelement due to Bad error (message?) aws_s3_bucket_lifecycle_configuration complains about "Base level prefix" when there is none hashicorp/terraform-provider-aws#23299