Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate config for noncurrent_version transition, add possible set lifecycle id #111

Closed
wants to merge 3 commits into from

Conversation

ByJacob
Copy link

@ByJacob ByJacob commented Oct 26, 2021

what

  • Adding a separate configuration to the noncurrent_version transaction
  • Added ability to configure id in lifecycle

why

  • We don't always want to have glacier rules for previous versions
  • Setting the ID allows you to easily find the life cycle you are interested in in AWS Management COnsole

references

  • I didn't create a ticket :)

@ByJacob ByJacob requested review from a team as code owners October 26, 2021 13:52
@ByJacob ByJacob requested review from jhosteny and brcnblc October 26, 2021 13:52
@ByJacob
Copy link
Author

ByJacob commented Dec 14, 2021

@jhosteny

@mergify
Copy link

mergify bot commented Feb 22, 2022

This pull request is now in conflict. Could you fix it @ByJacob? 🙏

@Nuru
Copy link
Contributor

Nuru commented Feb 25, 2022

@ByJacob Thank you for this contribution. We did not jump on it because it is not backwards compatible, meaning everyone using the module would have had to make changes to upgrade to the version including these changes. We have, however, now addressed these issues via PRs #134 and #135, so I am closing this PR.

@Nuru Nuru closed this Feb 25, 2022
@ByJacob ByJacob deleted the master branch February 28, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants