Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lifecycle rule IDs #134

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Add lifecycle rule IDs #134

merged 2 commits into from
Feb 24, 2022

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Feb 24, 2022

what

  • Add lifecycle_rule_ids

why

  • Lifecycle rules may have IDs in AWS provider v3.0 and are required to have them in v4.0, but this module did not support them. This feature is used by other modules that directly create S3 buckets, making it a requirement for this module to support it if we want to transparently migrate those modules to using this one.

@Nuru Nuru requested review from a team as code owners February 24, 2022 15:29
@Nuru Nuru requested review from max-lobur and nitrocode February 24, 2022 15:29
@Nuru
Copy link
Contributor Author

Nuru commented Feb 24, 2022

/test all

@Nuru Nuru changed the title Ease refactoring by adding backward compatible lifecycle IDs Add lifecycle rule IDs Feb 24, 2022
@Nuru
Copy link
Contributor Author

Nuru commented Feb 24, 2022

/test all

bridgecrew[bot]
bridgecrew bot reviewed Feb 24, 2022
View reviewed changes
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️   Due to 03778d2 - Pin AWS Provider to < 4.0 - 1 new error was added

Change details

Error ID Change Path Resource
BC_VUL_2 Added /test/src/go.sum undefined

@Nuru Nuru merged commit 6086145 into master-aws-v3 Feb 24, 2022
@Nuru Nuru deleted the aws-v3-lifecycle-id branch February 24, 2022 16:18
@Nuru Nuru mentioned this pull request Feb 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridgecrew bridgecrew[bot] bridgecrew[bot] left review comments

@max-lobur max-lobur Awaiting requested review from max-lobur max-lobur is a code owner automatically assigned from cloudposse/contributors

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Nuru