Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add delete_marker_replication_status in replication rules #126

Merged
merged 2 commits into from
Jan 11, 2022
Merged

feat: add delete_marker_replication_status in replication rules #126

merged 2 commits into from
Jan 11, 2022

Conversation

DesmondH0
Copy link
Contributor

what

  • There are no control ability for enable Delete marker replication in this module

why

  • The reason of this was because empty filter would always be generated in this line
  • And this will disable the Delete marker replication option in replication rule

references

@DesmondH0 DesmondH0 requested review from a team as code owners January 11, 2022 13:31
@Gowiem
Copy link
Member

Gowiem commented Jan 11, 2022

/test all

@Gowiem Gowiem merged commit 7932c20 into cloudposse:master Jan 11, 2022
@Gowiem
Copy link
Member

Gowiem commented Jan 11, 2022

@DesmondH0 Thanks for the contribution! Released as 0.45.0.

@DesmondH0
Copy link
Contributor Author

@DesmondH0 Thanks for the contribution! Released as 0.45.0.

wow....thanks, thats the fastest PR response I got so far 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@jamengual jamengual Awaiting requested review from jamengual jamengual was automatically assigned from cloudposse/contributors

@RothAndrew RothAndrew Awaiting requested review from RothAndrew RothAndrew was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DesmondH0 @Gowiem @cloudpossebot