Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add delete_marker_replication_status in replication rules #126

Merged
merged 2 commits into from
Jan 11, 2022
Merged

feat: add delete_marker_replication_status in replication rules #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e77fff
feat: add delete_marker_replication_status in replication rules
Jan 11, 2022
3e526fd
Auto Format
cloudpossebot Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@ resource "aws_s3_bucket" "default" {
# is required even if it empty, so we always implement `prefix` as a filter.
# OBSOLETE: prefix = try(rules.value.prefix, null)
status = try(rules.value.status, null)
# The `Delete marker replication` was disabled by default since empty filter created in Line 210, this needed to be "Enabled" to turn it on
delete_marker_replication_status = try(rules.value.delete_marker_replication_status, null)

destination {
# Prefer newer system of specifying bucket in rule, but maintain backward compatibility with
Expand Down
1 change: 1 addition & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ variable "s3_replication_rules" {
# priority = number
# prefix = string
# status = string
# delete_marker_replication_status = string
# # destination_bucket is specified here rather than inside the destination object
# # to make it easier to work with the Terraform type system and create a list of consistent type.
# destination_bucket = string # destination bucket ARN, overrides s3_replica_bucket_arn
Expand Down