Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with new S3 defaults. Add user permissions boundary. #178

Merged
merged 1 commit into from
May 6, 2023

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented May 6, 2023

what

  • Make compatible with new S3 defaults by setting S3 Object Ownership before setting ACL and disabling ACL if Ownership is "BucketOwnerEnforced"
  • Add optional permissions boundary input for IAM user created by this module
  • Create aws_s3_bucket_accelerate_configuration and aws_s3_bucket_versioning resources even when the feature is disabled, to enable drift detection

why

references

@Nuru Nuru requested review from a team as code owners May 6, 2023 00:38
@Nuru Nuru requested review from Gowiem and korenyoni May 6, 2023 00:38
@Nuru
Copy link
Contributor Author

Nuru commented May 6, 2023

/test all

@Nuru Nuru added the minor New features that do not break anything label May 6, 2023
@Nuru Nuru enabled auto-merge (squash) May 6, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor New features that do not break anything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACL error on first terraform apply
2 participants