fix: correct bucket name to fix broken -replication role

[amila-ku]

what

• Fixes replication IAM role name that gets created as '-replication'

why

• Replication IAM role name gets created as '-replication'. This made the replication role unsusable.
• Used Terraform version: 1.8.0

references

• Resolves Replication role is created as '-replication' #251

[vbrinza]

I am having the same issue.
Using the module directly from the Terragrunt source, so no way to set the "module" name as expected by the https://github.com/cloudposse/terraform-aws-s3-bucket/blob/main/replication.tf#L4 construction.
Normally we should append "replication" at the end of the "bucket_name" which is going to be good enough for all the cases.
Also in our local fork we have something like
role = var.s3_replication_role == null ? aws_iam_role.replication[0].arn : var.s3_replication_role
for when we want to setup a separate role for it.
@nitrocode can we make this change go further?

[nitrocode]

/terratest

[nitrocode]

/terratest

[nitrocode]

I added changes, ran tests, and approved. I cannot merge because I was the last person to push changes. I reached out to sweetops in the #pr-reviews slack channel for visibility

https://sweetops.slack.com/archives/CUJPCP1K6/p1731506086562779

[github-actions]

These changes were released in v4.7.2.

[nitrocode]

Thanks for the contribution @amila-ku 👍 and for the ping @vbrinza