Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct bucket name to fix broken -replication role #250

Merged
merged 5 commits into from
Nov 13, 2024
Merged

fix: correct bucket name to fix broken -replication role #250

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
20162b8
fix: fixes broken replication name
amila-ku Sep 18, 2024
93b4aac
fix: use local value
amila-ku Sep 28, 2024
920aef6
fix: use bucket name from local
amila-ku Sep 28, 2024
3349b03
Merge branch 'main' into fix/broken-replication-role-name
nitrocode Nov 13, 2024
34f9279
fix(replication): missing quote, created local
nitrocode Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions replication.tf
View file
Open in desktop
nitrocode marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
resource "aws_iam_role" "replication" {
count = local.replication_enabled ? 1 : 0

name = format("%s-replication", module.this.id)
name = "${aws_s3_bucket.default[0].id}-replication"
amila-ku marked this conversation as resolved.
Show resolved Hide resolved
assume_role_policy = data.aws_iam_policy_document.replication_sts[0].json
permissions_boundary = var.s3_replication_permissions_boundary_arn

Expand All @@ -28,7 +28,7 @@ data "aws_iam_policy_document" "replication_sts" {
resource "aws_iam_policy" "replication" {
count = local.replication_enabled ? 1 : 0

name = format("%s-replication", module.this.id)
name = "${aws_s3_bucket.default[0].id}-replication"
amila-ku marked this conversation as resolved.
Show resolved Hide resolved
policy = data.aws_iam_policy_document.replication[0].json

tags = module.this.tags
Expand Down