fix: use new destination.bucket key in policy #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nitrocode <[email protected]>
nitrocode
added
patch
|
/terratest |
gberenice
approved these changes
Nov 14, 2024
|
These changes were released in v4.7.3. |
vbrinza
added a commit
to verygood-ops/terraform-aws-s3-bucket
that referenced
this pull request
Nov 18, 2024
* fix: use new destination.bucket key in policy (cloudposse#256) Signed-off-by: nitrocode <[email protected]> * feat: support eventbridge bucket notification (cloudposse#255) * feat: add eventbridge * feat: add eventbridge to var definition * docs: update event notifications to support eventbridge Signed-off-by: nitrocode <[email protected]> --------- Signed-off-by: nitrocode <[email protected]> * feat: add s3 request payment config (cloudposse#259) * feat: add s3 request payment config var * fix: set optional key and add validation * feat: use s3 request payment config * fix: set default to BucketOwner * fix: validation for contains --------- Co-authored-by: Veronika Gnilitska <[email protected]> * chore: update README.md --------- Signed-off-by: nitrocode <[email protected]> Co-authored-by: RB <[email protected]> Co-authored-by: Veronika Gnilitska <[email protected]> Co-authored-by: readme-action 📖 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
destination_bucketand newdestination.bucketdestination.bucketand leftdestination_bucketfor backwards compatibility, as stated in variables.tf, and forgot to include the new value in the IAM policyreferences