Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new destination.bucket key in policy #256

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix: use new destination.bucket key in policy #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions replication.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
locals {
replication_role = format("%s-replication", local.bucket_name)
}

resource "aws_iam_role" "replication" {
count = local.replication_enabled ? 1 : 0

name = local.replication_role
name = format("%s-replication", local.bucket_name)
assume_role_policy = data.aws_iam_policy_document.replication_sts[0].json
permissions_boundary = var.s3_replication_permissions_boundary_arn

Expand All @@ -32,7 +28,7 @@ data "aws_iam_policy_document" "replication_sts" {
resource "aws_iam_policy" "replication" {
count = local.replication_enabled ? 1 : 0

name = local.replication_role
name = aws_iam_role.replication[0].name
policy = data.aws_iam_policy_document.replication[0].json

tags = module.this.tags
Expand Down Expand Up @@ -68,6 +64,7 @@ data "aws_iam_policy_document" "replication" {
resources = toset(concat(
try(length(var.s3_replica_bucket_arn), 0) > 0 ? ["${var.s3_replica_bucket_arn}/*"] : [],
[for rule in local.s3_replication_rules : "${rule.destination_bucket}/*" if try(length(rule.destination_bucket), 0) > 0],
[for rule in local.s3_replication_rules : "${rule.destination.bucket}/*" if try(length(rule.destination.bucket), 0) > 0],
))
}
}
Expand Down