Feat: Support Allowing Actions from Specific Principal ARNs in Bucket Policy.#95

Merged

korenyoni merged 29 commits intomasterfrom feat/deployment-arns

Jul 2, 2021

+448-97

Commits on Jun 29, 2021

Commits on Jun 30, 2021

Fix indentation in examples/complete module block.
korenyoni
committed
Auto Format
cloudpossebot
committed
Make use of account ID in examples/complete/privileged-principals.tf more DRY.
korenyoni
committed
Rename bucket prefixes used by examples/complete such that the example is more clear.
korenyoni
committed
Merge branch 'feat/deployment-arns' of github.com:cloudposse/terraform-aws-s3-bucket into feat/deployment-arns
korenyoni
committed
Auto Format
cloudpossebot
committed
Move privileged_principals_arn declaration to locals block to avoid terraform fmt issues.
korenyoni
committed
Merge branch 'feat/deployment-arns' of github.com:cloudposse/terraform-aws-s3-bucket into feat/deployment-arns
korenyoni
committed
Fix formatting in README.yaml.
korenyoni
committed
Auto Format
cloudpossebot
committed
Use aws_iam_policy_document data source instead of jsonencode(HCL) for IAM policies and IAM Role Assumption policies.
korenyoni
committed
Merge branch 'feat/deployment-arns' of github.com:cloudposse/terraform-aws-s3-bucket into feat/deployment-arns
korenyoni
committed
Auto Format
cloudpossebot
committed
Ensure var.user_enabled is acknowledged when examples/complete invokes the root-level module.
korenyoni
committed
Use var.enabled in null_label module invocations instead of count; ensure additional_deployment_principal_label is actually used by additional deployment IAM role.
korenyoni
committed
Merge branch 'feat/deployment-arns' of github.com:cloudposse/terraform-aws-s3-bucket into feat/deployment-arns
korenyoni
committed
Use consistent end-of-file newlines.
korenyoni
committed
Ensure all tfvars instantiate lists formatted line-by-line.
korenyoni
committed
Use unique seeds for each test's random ID.

korenyoni
and
Nuru
authored
Do not re-iterate through all array indices with every statement iteration for AllowPrivilegedPrincipal statement.

korenyoni
and
Nuru
authored
Ensure example fixtures with user_enabled=false do not later have the user_name output tested; re-order variables in privileged principals fixure.
korenyoni
committed
Change order of prefixes in expected bucket policy (to match actual policy).
korenyoni
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Support Allowing Actions from Specific Principal ARNs in Bucket Policy.#95

Commits on Jun 29, 2021

Support allowing actions from specific principal ARNs in bucket policy.

Auto Format

Run go fmt.

Commits on Jun 30, 2021

Fix indentation in examples/complete module block.

Auto Format

Make use of account ID in examples/complete/privileged-principals.tf more DRY.

Rename bucket prefixes used by examples/complete such that the example is more clear.

Merge branch 'feat/deployment-arns' of github.com:cloudposse/terraform-aws-s3-bucket into feat/deployment-arns

Auto Format

Move privileged_principals_arn declaration to locals block to avoid terraform fmt issues.

Merge branch 'feat/deployment-arns' of github.com:cloudposse/terraform-aws-s3-bucket into feat/deployment-arns

Fix formatting in README.yaml.

Auto Format

Use aws_iam_policy_document data source instead of jsonencode(HCL) for IAM policies and IAM Role Assumption policies.

Merge branch 'feat/deployment-arns' of github.com:cloudposse/terraform-aws-s3-bucket into feat/deployment-arns

Auto Format

Ensure var.user_enabled is acknowledged when examples/complete invokes the root-level module.

Use var.enabled in null_label module invocations instead of count; ensure additional_deployment_principal_label is actually used by additional deployment IAM role.

Merge branch 'feat/deployment-arns' of github.com:cloudposse/terraform-aws-s3-bucket into feat/deployment-arns

Use consistent end-of-file newlines.

Ensure all tfvars instantiate lists formatted line-by-line.

Use unique seeds for each test's random ID.

Do not re-iterate through all array indices with every statement iteration for AllowPrivilegedPrincipal statement.

Ensure example fixtures with user_enabled=false do not later have the user_name output tested; re-order variables in privileged principals fixure.

Change order of prefixes in expected bucket policy (to match actual policy).

Commits on Jul 2, 2021

Fix variable description; fix README snippet formatting.

Auto Format

Remove allowed_bucket_actions when user_enabled=false.

Fix formatting in privileged-principals.tf.