Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Support Allowing Actions from Specific Principal ARNs in Bucket Policy. #95

Merged
merged 29 commits into from
Jul 2, 2021
Merged

Feat: Support Allowing Actions from Specific Principal ARNs in Bucket Policy. #95

merged 29 commits into from
Jul 2, 2021

Conversation

korenyoni
Copy link
Member

@korenyoni korenyoni commented Jun 29, 2021 •
edited
Loading

what

  • Support allowing actions from specific principal ARNs in bucket policy.
  • Reorganize examples/complete (split up into multiple files to keep main.tf simple)
  • Misc: use local.enabled where possible

why

  • Some buckets that are used by CI/CD systems may need to allow actions from cross-account IAM principals in their bucket policy.

references

@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni marked this pull request as ready for review June 29, 2021 21:38
@korenyoni korenyoni requested review from a team as code owners June 29, 2021 21:38
@korenyoni korenyoni requested review from 3h4x, joe-niland and aknysh June 29, 2021 21:38
aknysh
aknysh reviewed Jun 29, 2021
View reviewed changes
examples/complete/main.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jun 29, 2021
View reviewed changes
examples/complete/main.tf Outdated Show resolved Hide resolved
aknysh
aknysh previously requested changes Jun 29, 2021
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

Nuru
Nuru previously requested changes Jun 30, 2021
View reviewed changes
README.yaml Outdated Show resolved Hide resolved
examples/complete/main.tf Outdated Show resolved Hide resolved
examples/complete/privileged-principals.tf Outdated Show resolved Hide resolved
examples/complete/privileged-principals.tf Outdated Show resolved Hide resolved
examples/complete/privileged-principals.tf Outdated Show resolved Hide resolved
examples/complete/privileged-principals.us-east-2.tfvars Outdated Show resolved Hide resolved
examples/complete/replication.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
test/src/examples_complete_test.go Outdated Show resolved Hide resolved
test/src/examples_complete_test.go Outdated Show resolved Hide resolved
@mergify mergify bot dismissed stale reviews from aknysh and Nuru June 30, 2021 13:28

This Pull Request has been updated, so we're dismissing all reviews.

@korenyoni korenyoni force-pushed the feat/deployment-arns branch 2 times, most recently from 90d6b67 to e523f73 Compare June 30, 2021 14:45
@korenyoni korenyoni force-pushed the feat/deployment-arns branch from e523f73 to 3b0ba44 Compare June 30, 2021 14:56
@korenyoni
Copy link
Member Author

/test all

1 similar comment
@korenyoni
Copy link
Member Author

/test all

@korenyoni
Ensure example fixtures with user_enabled=false do not later have the…
c39b5c0 
… user_name output tested; re-order variables in privileged principals fixure.
@korenyoni
Copy link
Member Author

/test all

@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni requested review from Nuru and aknysh June 30, 2021 16:47
aknysh
aknysh reviewed Jul 2, 2021
View reviewed changes
README.yaml Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jul 2, 2021
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments @korenyoni

@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni requested a review from aknysh July 2, 2021 19:16
@korenyoni korenyoni merged commit 54d3caf into master Jul 2, 2021
@korenyoni korenyoni deleted the feat/deployment-arns branch July 2, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@3h4x 3h4x Awaiting requested review from 3h4x

@joe-niland joe-niland Awaiting requested review from joe-niland

@Nuru Nuru Awaiting requested review from Nuru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@korenyoni @Nuru @aknysh @cloudpossebot