Properly type the default replication filter object

[alexjurkiewicz]

I think this error was introduced during some rewriting in #93.

[alexjurkiewicz]

Here's the error source: https://github.com/cloudposse/terraform-aws-s3-bucket/pull/93/files#diff-dc46acf24afd63ef8c556b77c126ccc6e578bc87e3aa09a931f33d9bf2532fbbR197

btw, this causes errors like

Error: Inconsistent conditional result types

  on .terraform/modules/my_bucket/main.tf line 197, in resource "aws_s3_bucket" "default":
 197:             for_each = try(rules.value.filter, null) == null ? ["empty"] : [rules.value.filter]
    |----------------
    | rules.value.filter is object with no attributes

The true and false result expressions must have consistent types. The given
expressions are tuple and tuple, respectively.

[korenyoni]

LGTM but let's leave the try block in for filter.value.tags

This Pull Request has been updated, so we're dismissing all reviews.

[korenyoni]

/test all

[korenyoni]

Looks good to me.