Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly type the default replication filter object #96

Merged
merged 4 commits into from
Jul 6, 2021
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -194,11 +194,11 @@ resource "aws_s3_bucket" "default" {
# If the corresponding rule requires no filter, an empty configuration block filter {} must be specified.
# See https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket
dynamic "filter" {
for_each = try(rules.value.filter, null) == null ? ["empty"] : [rules.value.filter]
for_each = try(rules.value.filter, null) == null ? [{ prefix = null, tags = {} }] : [rules.value.filter]

content {
prefix = try(filter.value.prefix, try(rules.value.prefix, null))
tags = try(filter.value.tags, {})
tags = filter.value.tags
alexjurkiewicz marked this conversation as resolved.
Show resolved Hide resolved
alexjurkiewicz marked this conversation as resolved.
Show resolved Hide resolved
}
}
}
Expand Down