Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Terraform cloudposse/s3-bucket/aws to v0.40.1 #3

Closed
wants to merge 2 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 9, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Type Update Change
cloudposse/s3-bucket/aws (source) module minor 0.38.0 -> 0.40.1

Release Notes

cloudposse/terraform-aws-s3-bucket

v0.40.1

Compare Source

🐛 Bug Fixes

Properly type the default replication filter object @​alexjurkiewicz (#​96) ### what Properly type the default replication filter object ### why An error exists — likely introduced during some rewriting in #​93 — where the default replication filter object is not properly typed, and causes issues with the ternary operator.

v0.40.0

Compare Source

Feat: Support Allowing Actions from Specific Principal ARNs in Bucket Policy. @​korenyoni (#​95) ##### what * Support allowing actions from specific principal ARNs in bucket policy. * Reorganize `examples/complete` (split up into multiple files to keep `main.tf` simple) * Misc: use `local.enabled` where possible ##### why * Some buckets that are used by CI/CD systems may need to allow actions from cross-account IAM principals in their bucket policy. ##### references * https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/160

v0.39.0

Compare Source

🚀 Enhancements
S3 Replication Improvements @​alexjurkiewicz (#​93) ##### Terraform plan impact

In order to support multiple S3 Bucket replication destinations, we must use the filter in the replication rule, even if there is nothing to filter. The filter, even if empty, conflicts with the prefix attribute of the rule (a v1 feature replaced in v2 with the filter). So we moved all prefix settings into the filter. Therefore, you may see Terraform make a change like this:

Click to show plan
- rules {
  - id       = "replication-test"
  - prefix   = "/main"
  - priority = 0
  - status   = "Enabled"

  - destination {
    - bucket        = "arn:aws:s3:::replication-target"
    - storage_class = "STANDARD"
  }

  - filter {}
- }

+ rules {
    + id       = "replication-test"
    + priority = 0
    + status   = "Enabled"

    + destination {
        + bucket        = "arn:aws:s3:::replication-target"
        + storage_class = "STANDARD"
      }

    + filter {
        + prefix = "/main"
        + tags   = {}
    + }
+ }
This change is harmless and can be applied without impact. ##### Deprecation

To provide consistency in naming, the replication_rules input has been deprecated in favor of s3_replication_rules. Existing code will continue to work, but new users should use s3_replication_rules and current users of replication_rules should update their code to use s3_replication_rules at their convenience.

what
@​alexjurkiewicz
  • Add support for multi-bucket S3 replication
  • Add support for easily adding cross-account replication destination bucket policy statements
@​korenyoni
  • Add test for S3 bucket replication configuration to provide better code coverage
@​Nuru
  • Convert v1 prefix to v2 filter to support multiple replication destinations
  • Rename replication_rules to s3_replication_rules for consistency
  • Move testing to us-east-2 region because that is where Cloud Posse prefers to do testing
why
  • Module currently does not support multi-bucket S3 replication
  • Adding cross-account replication destination bucket policy statements is currently a manual task with no site-specific uniqueness
references

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested review from a team as code owners July 9, 2021 01:00
@renovate renovate bot added the auto-update This PR was automatically generated label Jul 9, 2021
@renovate renovate bot requested a review from a team as a code owner July 9, 2021 01:00
@renovate renovate bot requested review from adamcrews and joe-niland and removed request for a team July 9, 2021 01:00
@mergify
Copy link

mergify bot commented Aug 21, 2021

This pull request is now in conflict. Could you fix it @renovate[bot]? 🙏

@woz5999 woz5999 closed this in #11 Mar 28, 2022
@renovate renovate bot deleted the renovate/cloudposse-s3-bucket-aws-0.x branch March 28, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update This PR was automatically generated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants