Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatible with Visual Studio Code (cmd) #1416

Merged
merged 1 commit into from
Nov 29, 2017
Merged

Compatible with Visual Studio Code (cmd) #1416

merged 1 commit into from
Nov 29, 2017

Conversation

gucong3000
Copy link
Contributor

@gucong3000 gucong3000 commented Jun 23, 2017 •
edited
Loading

image

@gucong3000 gucong3000 changed the title Compatible with Visual Studio Code Compatible with Visual Studio Code (cmd) Jun 23, 2017
@gucong3000
Copy link
Contributor Author

config.json of vscode

{
    "terminal.integrated.shell.windows": "cmd.exe",
    "terminal.integrated.shellArgs.windows": [
        "/k",
        "D:\\Program Files\\cmder\\vendor\\init.bat"
    ]
}

@Stanzilla
Copy link
Member

Can you explain why this is needed, please?

@gucong3000
Copy link
Contributor Author

Without is PR, vscode can not use cmder.

@gucong3000
Copy link
Contributor Author

And it will work for other IDEs.

@gucong3000
Copy link
Contributor Author

#1417

MartiUK
MartiUK approved these changes Sep 29, 2017
View reviewed changes
Copy link
Member

@MartiUK MartiUK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Stanzilla Stanzilla requested a review from daxgames October 29, 2017 16:10
@gucong3000
Copy link
Contributor Author

What can I do for help?

@MartiUK MartiUK merged commit ee4f85d into cmderdev:master Nov 29, 2017
@gucong3000 gucong3000 deleted the patch-1 branch November 29, 2017 14:43
@Stanzilla Stanzilla mentioned this pull request Jan 15, 2018
Closed
@tyler36 tyler36 mentioned this pull request Jan 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartiUK MartiUK MartiUK approved these changes

@daxgames daxgames Awaiting requested review from daxgames

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gucong3000 @Stanzilla @MartiUK