Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible with Visual Studio Code (PowerShell) #1417

Merged
merged 2 commits into from
Oct 31, 2017

Conversation

gucong3000
Copy link
Contributor

@gucong3000 gucong3000 commented Jun 23, 2017

image

@gucong3000
Copy link
Contributor Author

config.json of vscode

{
    "terminal.integrated.shell.windows": "powershell.exe",
    "terminal.integrated.shellArgs.windows": [
        "-ExecutionPolicy",
        "Bypass",
        "-NoLogo",
        "-NoProfile",
        "-NoExit",
        "-Command",
        "Invoke-Expression '. ''D:\\Program Files\\cmder\\vendor\\profile.ps1'''"
    ]
}

@Stanzilla
Copy link
Member

Hey sorry about that, but this has conflicts now

# Conflicts:
#	vendor/profile.ps1
Copy link
Member

@MartiUK MartiUK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Stanzilla Stanzilla requested a review from Jackbennett October 29, 2017 16:10
@Jackbennett
Copy link
Contributor

Jackbennett commented Oct 31, 2017

Tested it on my vscode 1.17.2 and it works fine.

Adding a note, VScode defaults to powershell these days and personally my systems have the execution policy as remotesigned so I only need;

"terminal.integrated.shellArgs.windows": [
    "-noExit",
    "-command",
    "invoke-expression '. ''C:\\f\\src\\cmder\\vendor\\profile.ps1'''"
  ]

The string has strange escaping.

@Jackbennett Jackbennett merged commit 7479d62 into cmderdev:master Oct 31, 2017
@gucong3000 gucong3000 deleted the patch-2 branch November 1, 2017 03:35
@lsq27
Copy link

lsq27 commented Nov 28, 2017

  • Anyone can help? This folder has a .git subfolder.
    image
    The warning is as follows
Missing git support, install posh-git with 'Install-Module posh-git' and restart cmder.
  • When I open a folder without a .git subfolder using vscode, everything is OK.
    image
    But if I cd into the git folder, it seems that cmder can't find post-install.bat?
    image

  • I think this may help on stackoverflow.

  • my config.json of vscode

    "terminal.integrated.shell.windows": "powershell.exe",
    "terminal.integrated.shellArgs.windows": [
        "-ExecutionPolicy",
        "Bypass",
        "-NoLogo",
        "-NoProfile",
        "-NoExit",
        "-Command",
        "Invoke-Expression '. ''D:\\Cmder\\vendor\\profile.ps1'''"
    ]

@gucong3000
Copy link
Contributor Author

@lsq27
Copy link

lsq27 commented Nov 28, 2017

@gucong3000 thank you, that works.
I have installed posh-git and everything works well.

@Dream4ever
Copy link

@gucong3000 Thank you very much, using posh-git and working very well in vscode!
Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants