Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline cron triggers to codefresh_pipeline #122

Merged
merged 5 commits into from
Aug 18, 2023
Merged

Add inline cron triggers to codefresh_pipeline #122

merged 5 commits into from
Aug 18, 2023

Conversation

oleksandr-codefresh
Copy link
Contributor

@oleksandr-codefresh oleksandr-codefresh commented Jul 25, 2023

What

[codefresh_pipeline]: add spec.cron_trigger

Why

New feature that supersedes pipeline_cron_trigger added in #90 (the API used by pipeline_cron_trigger is limited; additional cron trigger options were recently added to the pipelines API, currently behind a feature flag)

Notes

Will be first released as part of 0.6.0-beta-1 (pre-release)

Checklist

@oleksandr-codefresh oleksandr-codefresh changed the title CR-19574 pipeline.spec.crontTriggers CR-19574 pipeline.spec.cronTriggers Jul 25, 2023
@korenyoni korenyoni changed the title CR-19574 pipeline.spec.cronTriggers Add inline cron triggers to codefresh_pipeline Aug 10, 2023
@korenyoni
Copy link
Contributor

/test

@korenyoni korenyoni added the enhancement New feature or request label Aug 15, 2023
@korenyoni
Copy link
Contributor

/test

Copy link
Contributor

@korenyoni korenyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had to fix tests and create deprecations for pipeline_cron_trigger.

@korenyoni korenyoni merged commit 887901f into master Aug 18, 2023
@korenyoni korenyoni deleted the CR-19574 branch August 18, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs enhancement New feature or request source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants