Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Pipeline Cron Trigger #90

Merged
merged 55 commits into from
Oct 3, 2022
Merged

Conversation

korenyoni
Copy link
Contributor

@korenyoni korenyoni commented Sep 28, 2022

What

  • Add resource for Pipeline Cron Trigger
  • Fix Terraform Acceptance tests
  • Add Acceptance Tests to CI
  • Add release automation (release drafter, labeler, automatic changelog drafting)
  • GH Repo best practices (PULL_REQUEST_TEMPLATE, CODEOWNERS, etc)
  • Misc documentation fixes

Why

  • Only git triggers are currently supported.
  • Triggers should be a standalone resource. The next minor release (0.2.0) will support remaining standalone triggers (registry, helm, git).

Notes

korenyoni and others added 30 commits September 12, 2022 13:29
    This commit was created by changelog-from-release in 'Changelog from Release' CI workflow
…ni/terraform-provider-codefresh into feat/trigger-resource-separation
korenyoni and others added 5 commits September 28, 2022 17:26
Docs: Add Terraform Acceptance Tests Section to README
    This commit was created by changelog-from-release in 'Changelog from Release' CI workflow
    This commit was created by changelog-from-release in 'Changelog from Release' CI workflow
    This commit was created by changelog-from-release in 'Changelog from Release' CI workflow
@korenyoni korenyoni merged commit c14eb01 into codefresh-io:master Oct 3, 2022
korenyoni added a commit that referenced this pull request Aug 18, 2023
## What

`[codefresh_pipeline]`: add `spec.cron_trigger`

## Why

New feature that supersedes
[pipeline_cron_trigger](https://registry.terraform.io/providers/codefresh-io/codefresh/latest/docs/resources/pipeline_cron_trigger)
added in #90 (the API used by `pipeline_cron_trigger` is limited;
additional cron trigger options were recently added to the pipelines
API, currently behind a feature flag)

## Notes

Will be first released as part of `0.6.0-beta-1` (pre-release)

## Checklist

* [x] _I have read
[CONTRIBUTING.md](https://github.com/codefresh-io/terraform-provider-codefresh/blob/master/CONTRIBUTING.md)._
* [x] _I have [allowed changes to my fork to be
made](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork)._
* [x] _I have added tests, assuming new tests are warranted_.
* [x] _I understand that the `/test` comment will be ignored by the CI
trigger [unless it is made by a repo admin or
collaborator](https://codefresh.io/docs/docs/pipelines/triggers/git-triggers/#support-for-building-pull-requests-from-forks)._

---------

Co-authored-by: Yonatan Koren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to semantic versions Support CRON trigger type for pipeline
2 participants