Fix validation for empty body responses #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulocdf
force-pushed
the
fix-validation-for-empty-responses
branch
5 times, most recently
from
830598a to
e52cd70
Compare
|
The CHANGELOG gem thing has gotten more strict. Care to fix it in this PR @paulocdf? Or lock danger-changelog back to the older release. |
paulocdf
force-pushed
the
fix-validation-for-empty-responses
branch
from
e52cd70 to
c4f696c
Compare
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the situation where responses from a server that do not have a body throw an
InvalidRepresentationError. This situation is common for DELETE requests where the 204 (No Content) is a valid response.The
validatemethod was changed to return an empty hash if the givenrepresentationisnilor an empty string.