Fix danger warnings for changelog #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoanjo
force-pushed
the
make-danger-happy
branch
17 times, most recently
from
2efeea8 to
b3cdf0f
Compare
ivoanjo
force-pushed
the
make-danger-happy
branch
from
b3cdf0f to
001cc06
Compare
Testing on 2.2 was failing in Travis due to an incompatibility between Bundler 2 and Ruby 2.2 (see <https://docs.travis-ci.com/user/languages/ruby/#bundler-20> for more details). Because Ruby 2.2 is EOL for more than a year now (see <https://www.ruby-lang.org/en/news/2018/06/20/support-of-ruby-2-2-has-ended/>) rather than work around this, let's just drop that version from the Travis matrix.
|
Thanks for this! Please do PR some doc updates into danger-changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed the date formats, as well as the extra notes.
@dblock I just noticed that you own https://github.com/dblock/danger-changelog/ and I think it's missing a bit of documentation around what it considers a well-formed changelog (e.g. showing off all of the possible use cases, or a "complex" changelog).
Getting it to accept hyperclient's
CHANGELOGagain was a bit trial-and-error as the error message was a bit too generic.