add faraday connection options without breaking api

[koenpunt]

SSL options can only be passed to Faraday on initialization. So I've added a connection_options property which is passed to Faraday directly.

Hyperclient.new('https://api.example.com/') do |client|
  client.connection_options = { ssl: { verify: false } }
  client.connection do |conn|
    conn.authorization :Bearer, 'ioP_pcKLhB4NLMGKMM6B40rwkBC.5o2JpsnBHhmKs4QAExG'
  end
end

I think it would be better if the options hash of connection would be passed to Faraday, then we can simply write:

Hyperclient.new('https://api.example.com/') do |client|
  client.connection(ssl: { verify: false }) do |conn|
    conn.authorization :Bearer, 'ioP_pcKLhB4NLMGKMM6B40rwkBC.5o2JpsnBHhmKs4QAExG'
  end
end

But this means the use options[:default] should be changed to something like a property of the client, and thus breaking the API.

[koenpunt]

Just found that I can use the update method on the SslOptions:

Hyperclient.new('https://api.example.com/') do |client|
  client.connection do |conn|
    conn.ssl.update(verify: false)
    conn.authorization :Bearer, 'ioP_pcKLhB4NLMGKMM6B40rwkBC.5o2JpsnBHhmKs4QAExG'
  end
end

But I still think it would be nice to set the Faraday options in the connection method.

[dblock]

I'm down with this, but it needs a test, README and CHANGELOG updates, please.

[koenpunt]

:default is now implicit. Which means that default: true is not necessary, but also means this change is backwards compatible.

[dblock]

I don't think you should be deleteing items from here because this is a hash passed from the outside. Also comparing to false is probably a bad idea. If you need to check whether the value is present at all, use key?.

[koenpunt]

This is because :default is of no use for Faraday. But yeah, I'm not exactly cool with it either..

[koenpunt]

Could use @faraday_options = options.dup though

[dblock]

If you are going to delete, yes.

[dblock]

This is nice work. See my comment(s) above. Don't forget CHANGELOG, README and please squash the commits if appropriate.

[koenpunt]

Working on the README and CHANGELOG as we speak ;)

[koenpunt]

The weird whitespace in entry_point_test.rb is because not all describe blocks were nested in describe EntryPoint do

[dblock]

Btw, I usually just keep these things under Next. That's because there's no actual -pre release, so it may be confusing for someone reading it. It's no big deal.

[dblock]

Merging.