-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use application/hal+json as default Content-Type and add to Accept header #81
Conversation
Needs tests, CHANGELOG and possible README updates please. |
I think the At least according to the spec: https://github.com/mikekelly/hal_specification/blob/master/hal_specification.md#how-to-serve-hal |
You mean the default content-type? Yes. |
I'll update the CHANGELOG in a bit |
For now tagged it as |
This is good, would you mind rebasing and squashing your commits please? |
add application/hal+json to 'Accept' header add custom middleware for json+hal
Done, and what do you think of my suggestion in #80? |
Use application/hal+json as default Content-Type and add to Accept header
I did comment on #80, I would take the change, just needs README, CHANGELOG, tests, etc. |
Yeah I know, I meant to wait with the release because it could break things. |
Not every api accepts the
application/json
header.