Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ru] fix grammar errors and add missing items #372

Merged
merged 17 commits into from
Mar 3, 2023
Merged

[ru] fix grammar errors and add missing items #372

merged 17 commits into from
Mar 3, 2023

Conversation

MalkoVrinto
Copy link
Contributor

fixed some grammar errors

Encryption.php : russian language
Fabricator.php : russian language
HTTP.php : russian language
Number.php : russian language
@kenjis
Copy link
Member

kenjis commented Feb 26, 2023

Thank you for sending updates.

But it seems there are many missing translation items.
See https://github.com/codeigniter4/translations/actions/runs/4270646474/jobs/7439409028
Can you add them?

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the missing keys would be great, but I'm also okay with this as an in-place improvement.

@paulbalandan paulbalandan changed the title updated the russian translation [ru] fix grammar errors Feb 26, 2023
added russian translation of Cookie.php
added russian translation of Publisher.php
added russian translation of Errors.php
@MalkoVrinto
Copy link
Contributor Author

MalkoVrinto commented Mar 1, 2023

Thank you for sending updates.

But it seems there are many missing translation items. See https://github.com/codeigniter4/translations/actions/runs/4270646474/jobs/7439409028 Can you add them?

With my pleasure

P.S. Added missed:
Cookie.php
Errors.php
Publisher.php
Security.php
Test.php

added russian translation of Security.php
added russian translation of Test.php
@kenjis
Copy link
Member

kenjis commented Mar 2, 2023

Thank you for adding files!

These items are not translated:

Failed asserting that the language keys "CLI.altCommandPlural", "CLI.altCommandSingular", "CLI.generator.cancelOperation", "CLI.generator.className.cell", "CLI.generator.className.command", "CLI.generator.className.config", "CLI.generator.className.controller", "CLI.generator.className.default", "CLI.generator.className.entity", "CLI.generator.className.filter", "CLI.generator.className.migration", "CLI.generator.className.model", "CLI.generator.className.seeder", "CLI.generator.className.validation", "CLI.generator.commandType", "CLI.generator.databaseGroup", "CLI.generator.fileCreate", "CLI.generator.fileError", "CLI.generator.fileExist", "CLI.generator.fileOverwrite", "CLI.generator.parentClass", "CLI.generator.returnType", "CLI.generator.tableName", "CLI.generator.usingCINamespace", "CLI.generator.viewName.cell", "CLI.namespaceNotDefined", "Cast.baseCastMissing", "Cast.invalidCastMethod", "Cast.invalidTimestamp", "Core.invalidPhpVersion", "Database.emptyPrimaryKey", "Database.methodNotAvailable", "Fabricator.createFailed", "Files.expectedDirectory", "Files.expectedFile", "Format.invalidFormatter", "Format.invalidMime", "HTTP.invalidSameSiteSetting", "HTTP.localeNotSupported", "Images.webpNotSupported", "Log.invalidMessageType", "Migrations.batch", "Migrations.group", "Migrations.migrated", "Migrations.nameSeeder", "Migrations.namespace", "Router.invalidControllerName", "Router.invalidDynamicController", "Session.invalidSameSiteSetting", "Time.invalidFormat", "Validation.not_in_list", "Validation.valid_json", "View.invalidDecoratorClass" in the main repository are included for translation in "ru" locale.
https://github.com/codeigniter4/translations/actions/runs/4305274333/jobs/7517427605

added missing keys in ru_RU Cast.php
added missing key <<invalidPhpVersion>> in ru_RU Core.php
Added missed <<emptyPrimaryKey>> and <<methodNotAvailable>> in ru_RU Database.php
added missing <<createFailed>> in ru_RU Fabricator.php
added missing <<expectedDirectory>> and <<expectedFile>> in ru_RU Files.php
added missing <<invalidFormatter>> and <<invalidMime>> in ru_RU Format.php
@MalkoVrinto
Copy link
Contributor Author

Thank you for adding files!

These items are not translated:

Failed asserting that the language keys "CLI.altCommandPlural", "CLI.altCommandSingular", "CLI.generator.cancelOperation", "CLI.generator.className.cell", "CLI.generator.className.command", "CLI.generator.className.config", "CLI.generator.className.controller", "CLI.generator.className.default", "CLI.generator.className.entity", "CLI.generator.className.filter", "CLI.generator.className.migration", "CLI.generator.className.model", "CLI.generator.className.seeder", "CLI.generator.className.validation", "CLI.generator.commandType", "CLI.generator.databaseGroup", "CLI.generator.fileCreate", "CLI.generator.fileError", "CLI.generator.fileExist", "CLI.generator.fileOverwrite", "CLI.generator.parentClass", "CLI.generator.returnType", "CLI.generator.tableName", "CLI.generator.usingCINamespace", "CLI.generator.viewName.cell", "CLI.namespaceNotDefined", "Cast.baseCastMissing", "Cast.invalidCastMethod", "Cast.invalidTimestamp", "Core.invalidPhpVersion", "Database.emptyPrimaryKey", "Database.methodNotAvailable", "Fabricator.createFailed", "Files.expectedDirectory", "Files.expectedFile", "Format.invalidFormatter", "Format.invalidMime", "HTTP.invalidSameSiteSetting", "HTTP.localeNotSupported", "Images.webpNotSupported", "Log.invalidMessageType", "Migrations.batch", "Migrations.group", "Migrations.migrated", "Migrations.nameSeeder", "Migrations.namespace", "Router.invalidControllerName", "Router.invalidDynamicController", "Session.invalidSameSiteSetting", "Time.invalidFormat", "Validation.not_in_list", "Validation.valid_json", "View.invalidDecoratorClass" in the main repository are included for translation in "ru" locale.
https://github.com/codeigniter4/translations/actions/runs/4305274333/jobs/7517427605

Already translated :)

@paulbalandan paulbalandan changed the title [ru] fix grammar errors [ru] fix grammar errors and add missing items Mar 3, 2023
@paulbalandan paulbalandan merged commit 5b7fc9d into codeigniter4:develop Mar 3, 2023
@paulbalandan
Copy link
Member

Thank you, @MalkoVrinto for your contribution!

@MalkoVrinto
Copy link
Contributor Author

Thank you, @MalkoVrinto for your contribution!

🤝

@kenjis
Copy link
Member

kenjis commented Mar 9, 2023

It seems ru is broken now.

1) Translations\Tests\RussianTranslationTest::testAllConfiguredLanguageKeysAreInOrder with data set "ru" ('ru')
Failed asserting that the translated language keys in "ru" locale are ordered correctly.
--- Original
+++ Translated

Migrations.php:
-'migSeeder' => 'Seeder name';
+'on' => 'Миграция на: ';
Failed asserting that an array is empty.

See https://github.com/codeigniter4/translations/actions/runs/4370681286/jobs/7645827066

@MalkoVrinto
Copy link
Contributor Author

It seems ru is broken now.

1) Translations\Tests\RussianTranslationTest::testAllConfiguredLanguageKeysAreInOrder with data set "ru" ('ru')
Failed asserting that the translated language keys in "ru" locale are ordered correctly.
--- Original
+++ Translated

Migrations.php:
-'migSeeder' => 'Seeder name';
+'on' => 'Миграция на: ';
Failed asserting that an array is empty.

See https://github.com/codeigniter4/translations/actions/runs/4370681286/jobs/7645827066

The keys in Migrations.php are ordered correctly now.

@kenjis
Copy link
Member

kenjis commented Mar 11, 2023

The keys in Migrations.php are not ordered correctly:

'on' => 'Миграция на: ',
'migSeeder' => 'Имя SEEDER`a',

'migSeeder' => 'Seeder名', // 'Seeder name'
'migMissingSeeder' => 'Seeder名が必要です。', // 'You must provide a seeder name.'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants