-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ru] fix grammar errors and add missing items #372
Conversation
Encryption.php : russian language
Fabricator.php : russian language
HTTP.php : russian language
Number.php : russian language
Thank you for sending updates. But it seems there are many missing translation items. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the missing keys would be great, but I'm also okay with this as an in-place improvement.
added russian translation of Cookie.php
added russian translation of Publisher.php
added russian translation of Errors.php
With my pleasureP.S. Added missed: |
added russian translation of Security.php
added russian translation of Test.php
Thank you for adding files! These items are not translated:
|
added missing keys in ru_RU Cast.php
added missing key <<invalidPhpVersion>> in ru_RU Core.php
Added missed <<emptyPrimaryKey>> and <<methodNotAvailable>> in ru_RU Database.php
added missing <<createFailed>> in ru_RU Fabricator.php
added missing <<expectedDirectory>> and <<expectedFile>> in ru_RU Files.php
added missing <<invalidFormatter>> and <<invalidMime>> in ru_RU Format.php
Already translated :) |
Thank you, @MalkoVrinto for your contribution! |
🤝 |
It seems ru is broken now. 1) Translations\Tests\RussianTranslationTest::testAllConfiguredLanguageKeysAreInOrder with data set "ru" ('ru')
Failed asserting that the translated language keys in "ru" locale are ordered correctly.
--- Original
+++ Translated
Migrations.php:
-'migSeeder' => 'Seeder name';
+'on' => 'Миграция на: ';
Failed asserting that an array is empty. See https://github.com/codeigniter4/translations/actions/runs/4370681286/jobs/7645827066 |
The keys in Migrations.php are ordered correctly now. |
The keys in Migrations.php are not ordered correctly: translations/Language/ru/Migrations.php Lines 45 to 46 in 5b7fc9d
translations/Language/ja/Migrations.php Lines 45 to 46 in 5b7fc9d
|
fixed some grammar errors