Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common.py --- collapse whitespace for all langs #80

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Conversation

JRMeyer
Copy link
Contributor

@JRMeyer JRMeyer commented Jan 30, 2019

this collapses multiple spaces and tabs into one, single whitespace.

this is language independent

Copy link
Contributor

@kdavis-mozilla kdavis-mozilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PS: Are there any languages where repeated white space has meaning?

@JRMeyer
Copy link
Contributor Author

JRMeyer commented Jan 31, 2019

@kdavis-mozilla - there might be some writing rules in some language (i.e. only use tabs at the beginning of a paragraph), but in terms of "alphabetic" or "phonetic" meaning, no.

@JRMeyer JRMeyer merged commit 0eafd2a into master Jan 31, 2019
@JRMeyer JRMeyer deleted the whitespace branch January 31, 2019 10:33
@kdavis-mozilla
Copy link
Contributor

Found this strange thing Ogham has the space " " which would get replaced with " " by the code

sentence = (' ').join(sentence.split())

But as far as I know Ogham is not spoken. So we're fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants