-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coin-cgl: add 0.60.6 + conan v2 support #15838
Conversation
I detected other pull requests that are modifying coin-cgl/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
0f4aaeb
to
fde010a
Compare
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 5 (
Conan v2 pipeline (informative, not required for merge) ✔️
All green in build 6 ( |
if self._settings_build.os == "Windows": | ||
# TODO: Something to fix in conan client or pkgconf recipe? | ||
# This is a weird workaround when build machine is Windows. Here we have to inject regular | ||
# Windows path to pc files folder instead of unix path flavor injected by AutotoolsToolchain... | ||
env.define("PKG_CONFIG_PATH", self.generators_folder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jcar87 There's some suspicious code 🏫
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
related issue (for coin-osi): conan-io/conan#13098
* conan v2 support * add 0.60.6 * fix PKG_CONFIG_PATH on Windows
* conan v2 support * add 0.60.6 * fix PKG_CONFIG_PATH on Windows
this PR requires #15746, #15834 & #15836 (fix pkg_config_name for PkgConfigDeps).