Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coin-cgl: add 0.60.6 + conan v2 support #15838

Merged
merged 3 commits into from
Apr 2, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Feb 9, 2023

this PR requires #15746, #15834 & #15836 (fix pkg_config_name for PkgConfigDeps).


@ghost
Copy link

ghost commented Feb 9, 2023

I detected other pull requests that are modifying coin-cgl/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm changed the title coin-cgl: conan v2 support coin-cgl: add 0.60.6 + conan v2 support Feb 9, 2023
@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Feb 12, 2023
3 tasks
@stale
Copy link

stale bot commented Mar 12, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 12, 2023
@SpaceIm SpaceIm closed this Mar 12, 2023
@SpaceIm SpaceIm reopened this Mar 12, 2023
@stale stale bot removed the stale label Mar 12, 2023
@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm closed this Mar 28, 2023
@SpaceIm SpaceIm reopened this Mar 28, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (c5956e296859cb4c902e4646f72183b64da6912e):

  • coin-cgl/0.60.3@:
    All packages built successfully! (All logs)

  • coin-cgl/0.60.6@:
    All packages built successfully! (All logs)


Conan v2 pipeline (informative, not required for merge) ✔️

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

All green in build 6 (c5956e296859cb4c902e4646f72183b64da6912e):

  • coin-cgl/0.60.3@:
    All packages built successfully! (All logs)

  • coin-cgl/0.60.6@:
    All packages built successfully! (All logs)

Comment on lines +104 to +108
if self._settings_build.os == "Windows":
# TODO: Something to fix in conan client or pkgconf recipe?
# This is a weird workaround when build machine is Windows. Here we have to inject regular
# Windows path to pc files folder instead of unix path flavor injected by AutotoolsToolchain...
env.define("PKG_CONFIG_PATH", self.generators_folder)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcar87 There's some suspicious code 🏫

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related issue (for coin-osi): conan-io/conan#13098

@conan-center-bot conan-center-bot merged commit 606b3df into conan-io:master Apr 2, 2023
@SpaceIm SpaceIm deleted the coin-cgl-conan-v2 branch April 2, 2023 08:40
0xFireWolf pushed a commit to 0xFireWolf/conan-center-index that referenced this pull request Apr 2, 2023
* conan v2 support

* add 0.60.6

* fix PKG_CONFIG_PATH on Windows
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Apr 7, 2023
* conan v2 support

* add 0.60.6

* fix PKG_CONFIG_PATH on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants