Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coin-clp: conan v2 support #15836

Merged
merged 2 commits into from
Mar 28, 2023
Merged

coin-clp: conan v2 support #15836

merged 2 commits into from
Mar 28, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Feb 9, 2023

this PR requires #15746 & #15834 (fix pkg_config_name for PkgConfigDeps).

@ghost ghost mentioned this pull request Feb 9, 2023
Closed
@ghost
Copy link

ghost commented Feb 9, 2023

I detected other pull requests that are modifying coin-clp/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Feb 9, 2023
Merged
3 tasks
@github-actions github-actions bot mentioned this pull request Feb 9, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm mentioned this pull request Feb 9, 2023
Merged
3 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm mentioned this pull request Feb 9, 2023
Closed
3 tasks
@SpaceIm SpaceIm changed the title coin-clp: conan v2 support coin-clp: add 1.17.7 + conan v2 support Feb 9, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Feb 9, 2023
Open
Closed
@SpaceIm SpaceIm changed the title coin-clp: add 1.17.7 + conan v2 support coin-clp: conan v2 support Feb 11, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm mentioned this pull request Mar 3, 2023
Merged
3 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Mar 11, 2023 •
edited
Loading 

ERROR: Missing prebuilt package for 'coin-osi/0.108.7', 'coin-utils/2.11.6'
Check the available packages using 'conan list coin-utils/2.11.6:* -r=remote'
or try to build locally from sources using the '--build=coin-osi/0.108.7 --build=coin-utils/2.11.6' argument

#16262 will generate coin-utils v2 packages, and it should allow to build coin-osi (unless there are some issue with C++17 like there was in coin-utils).

@SpaceIm SpaceIm marked this pull request as draft March 20, 2023 21:03
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Mar 20, 2023

draft until #16633 is merged

@hedtke hedtke mentioned this pull request Mar 21, 2023
Merged
3 tasks
@SpaceIm SpaceIm closed this Mar 24, 2023
@SpaceIm SpaceIm reopened this Mar 24, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (9f194710fbd46b0aaa53c5da6e8785924e7e4019):

  • coin-clp/1.17.7@:
    All packages built successfully! (All logs)

  • coin-clp/1.17.6@:
    All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ✔️

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

All green in build 8 (9f194710fbd46b0aaa53c5da6e8785924e7e4019):

  • coin-clp/1.17.7@:
    All packages built successfully! (All logs)

  • coin-clp/1.17.6@:
    All packages built successfully! (All logs)

@SpaceIm SpaceIm marked this pull request as ready for review March 24, 2023 22:13
prince-chrismc
prince-chrismc reviewed Mar 28, 2023
View reviewed changes
recipes/coin-clp/all/conanfile.py
@@ -1,14 +1,15 @@
from conan import ConanFile
from conan.errors import ConanInvalidConfiguration
from conan.tools.files import get, apply_conandata_patches, mkdir, rm, rmdir, rename
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to no move things so much, it makes the diff bigger and less likely to be reviewed with the huge backlog 🙏

@conan-center-bot conan-center-bot merged commit 825d826 into conan-io:master Mar 28, 2023
@SpaceIm SpaceIm deleted the coin-clp-conan-v2 branch March 28, 2023 18:28
0xFireWolf pushed a commit to 0xFireWolf/conan-center-index that referenced this pull request Apr 2, 2023
@SpaceIm @0xFireWolf
(conan-io#15836) coin-clp: conan v2 support
9450588 
* conan v2 support

* add package_type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@jcar87 jcar87 Awaiting requested review from jcar87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SpaceIm @conan-center-bot @AbrilRBS @prince-chrismc