New recipe openmvg/2.0 #16356

SpaceIm · 2023-03-03T00:37:54Z

To pass v2 pipeline, this PR needs:

conan v2 support of ceres-solver recipe (ceres-solver: conan v2 support + deprecate use_gflags option + drop 1.13.0 #14855)
conan v2 support of coin-clp recipe (coin-clp: conan v2 support #15836)
fix lz4 traits in flann recipe (flann: fix visibility of lz4 (public dependency) #16355)

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

SpaceIm · 2023-03-08T09:19:53Z

In file included from /home/conan/w/prod/BuildSingleReference/.conan/data/ceres-solver/2.1.0/_/_/package/b1072642c81a88991afa656acd85c877932538ff/include/ceres/internal/autodiff.h:152:0,
                 from /home/conan/w/prod/BuildSingleReference/.conan/data/ceres-solver/2.1.0/_/_/package/b1072642c81a88991afa656acd85c877932538ff/include/ceres/autodiff_cost_function.h:130,
                 from /home/conan/w/prod/BuildSingleReference/.conan/data/ceres-solver/2.1.0/_/_/package/b1072642c81a88991afa656acd85c877932538ff/include/ceres/ceres.h:37,
                 from /home/conan/w/prod/BuildSingleReference/.conan/data/openmvg/2.0/_/_/build/64dfdd808a505f8687fad1d257cd11c4d1094a26/src/src/openMVG/multiview/rotation_averaging_l1.cpp:33:
/home/conan/w/prod/BuildSingleReference/.conan/data/ceres-solver/2.1.0/_/_/package/b1072642c81a88991afa656acd85c877932538ff/include/ceres/jet.h:194:13: error: specialization of â€˜template<class ... _Tp> struct std::common_typeâ€™ in different namespace [-fpermissive]

OpenMVG seems to rely on a ceres-solver header which hits a GCC bug fixed in GCC7 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56480).

SpaceIm · 2023-03-23T22:09:48Z

Converted to draft until merge of #15836 & #16355 to allow passing v2 pipeline.

github-actions · 2023-03-25T16:49:08Z

Hooks produced the following warnings for commit 96e26a1

openmvg/2.0

post_package(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './include/openMVG/sfm/pipelines/localization/SfM_Localizer_Single_3DTrackObservation_Database.hpp' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

SpaceIm · 2023-04-01T13:21:57Z

ERROR: Missing binary: coin-lemon/1.3.1:8631cf963dbbb4d7a378a64a6fd1dc57558bc2fe

coin-lemon/1.3.1: WARN: Can't find a 'coin-lemon/1.3.1' package binary '8631cf963dbbb4d7a378a64a6fd1dc57558bc2fe' for the configuration:
[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.cppstd=gnu17
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
fPIC=True
shared=False

ERROR: Missing prebuilt package for 'coin-lemon/1.3.1'
Check the available packages using 'conan list coin-lemon/1.3.1:* -r=remote'
or try to build locally from sources using the '--build=coin-lemon/1.3.1' argument

More Info at 'https://docs.conan.io/2/knowledge/faq.html#error-missing-prebuilt-package'

@danimtb @uilianries coud you generate v2 packages of coin-lemon please?

Well I've opened #16846

SpaceIm · 2023-04-03T12:24:07Z

Errors in v2 pipeline for Linux/all shared (https://c3i.jfrog.io/c3i/misc-v2/logs/pr/16356/13-linux-gcc/openmvg/2.0//420b80fc6515bf813bb6636821a1a154a4010d07-build.txt) likely come from a conan issue in CMakeDeps: conan-io/conan#13560

SpaceIm · 2023-04-30T21:47:48Z

@uilianries @prince-chrismc @SSE4 @jwillikers could you review this one please? It's ready for 1 month, and I don't think it can pass v2 pipeline on Linux without a fix of conan-io/conan#13560 in conan client.

recipes/openmvg/all/conanfile.py

conan-center-bot · 2023-05-01T01:13:48Z

Conan v1 pipeline ✔️

All green in build 15 (df4c6a8b9eadc08c3b575e14b9d30abe4d959adb):

openmvg/2.0@:
All packages built successfully! (All logs)

Conan v2 pipeline ❌

Note: Conan v2 builds may be required once they are on the v2 ready list

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 14 (df4c6a8b9eadc08c3b575e14b9d30abe4d959adb):

openmvg/2.0@:
CI failed to create some packages (All logs)

Logs for packageID 5a71b67b688b470ea016d52ea23d416a64e66c8c:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.cppstd=gnu17
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
*/*:shared=False

[...]
    coin-clp/1.17.7#fb18520c2691b592e406158a5e1d490b:63a76c2695c0c2df2a6d8bcd93929f98099cdeca#2835d87b7402d7a036a833e73b0fe495 - Download (conan-center)
    coin-lemon/1.3.1#88656bcbc28438aed6781d16c953d11b:8631cf963dbbb4d7a378a64a6fd1dc57558bc2fe#7f2bde6b7a7f0f21a2125428c3c2fa15 - Download (conan-center)
    coin-osi/0.108.7#b73f68c45c7a1f570c8f062a0b6d195c:406fe3af808400d2f757ae633f14c73000841dfe#d17e5f5c9621bfdd664e6323067a3feb - Download (conan-center)
    coin-utils/2.11.6#b15e35406c9642589a4d517b56a0c0aa:2e1536096dc69fc17603d8dbb68c916406ace94b#4d9a5464d9a5c9a4e7aed7caac411ae2 - Download (conan-center)
    eigen/3.4.0#2e192482a8acff96fe34766adca2b24c:da39a3ee5e6b4b0d3255bfef95601890afd80709#b2e7c2d86c5d1dbefc534889aa72e12c - Download (conan-center)
    flann/1.9.2#9a94fb20c9db33ab6102182ee62f671c:1049bf65f3345de4542f9cae675c6c46f36e8532#a4129a282c1d90a1236cccf40290ad43 - Download (conan-center)
    jbig/20160605#2d29fa02aacd76902e0d2cbbc24631ef:d529a33abf04a079c05de395d985d1a67619d741#3f360af5e9436f349a68fa935680ed69 - Download (conan-center)
    libdeflate/1.18#3697b637656a9af04cabcbed50db9a7e:b647c43bfefae3f830561ca202b6cfd935b56205#e0a3cb9dcec4fffa76e000528d45bcf3 - Download (conan-center)
    libjpeg/9e#68269859e4325ddc3f995d1fd3fc9187:b647c43bfefae3f830561ca202b6cfd935b56205#56f2c1d03929a9c088a0994c1be8f0b8 - Download (conan-center)
    libpng/1.6.39#a4953955f060811c79abff9fe986b6fe:52e28526917bc008177a3c5cf92ea21144c3ecd5#1c55fbd0915f150fa76d76e2033e375a - Download (conan-center)
    libtiff/4.5.0#f0b4e33992f03ee7a3ceb9e02f8ec6af:dc67ba67435c922fc090f1c31efaff47b0763c1b#331f05cc84e92500fb353e21a431d8a1 - Download (conan-center)
    libwebp/1.3.0#d92654dbce1f8cb8ae45d5388f86fcfe:18f01a3f175888d5e3d128efe30c14773afadc83#466944b37da5ec7f84fc20019a80f28f - Download (conan-center)
    lz4/1.9.4#bce1f314775b83c195dffc8e177ff368:b647c43bfefae3f830561ca202b6cfd935b56205#212caa6df47bd74fcf239400cc1c8691 - Download (conan-center)
    openmvg/2.0#647457f803f4c292b5e4908e5ade54e5:5a71b67b688b470ea016d52ea23d416a64e66c8c - Build
    xz_utils/5.4.2#b6ee8320403def553418874435445982:b647c43bfefae3f830561ca202b6cfd935b56205#8fc3ace4ab4dcc06c5685e4200df0d1a - Download (conan-center)
    zlib/1.2.13#e377bee636333ae348d51ca90874e353:b647c43bfefae3f830561ca202b6cfd935b56205#c68df5ae1b6d523306693ef4295b670f - Download (conan-center)
    zstd/1.5.5#93372fe14bb7883bd4de82914e0a1841:668e7888fadd10ea273722487025fa96b62e2a52#293969474624c87af50d805e497561d1 - Download (conan-center)
Build requirements
    gnu-config/cci.20210814#15c3bf7dfdb743977b84d0321534ad90:da39a3ee5e6b4b0d3255bfef95601890afd80709#22618e30bd9e326eb95e824dc90cc860 - Skip
    meson/1.0.0#15586c0ac6f682805875ef903dbe7ee2:da39a3ee5e6b4b0d3255bfef95601890afd80709#5c8fd51fc33f12e26519674d99afd0e5 - Skip
    ninja/1.11.1#63bca91350508f335754f5f9e17ec989:3593751651824fb813502c69c971267624ced41a#a53f170b60a46aef75ead8658bdeae05 - Skip
    pkgconf/1.9.3#a920b5c7f8d04f22b9fe03db91a864dd:c0b621fd4b3199fe05075171573398833dba85f4#a231c33e360d8be4e90467b36b88f027 - Skip

======== Installing packages ========
ERROR: Missing binary: ceres-solver/2.1.0:de0060c16e17cd1c56cbcceed5a819e6ab30b19b

ceres-solver/2.1.0: WARN: Can't find a 'ceres-solver/2.1.0' package binary 'de0060c16e17cd1c56cbcceed5a819e6ab30b19b' for the configuration:
[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.cppstd=gnu17
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
fPIC=True
shared=False
use_custom_blas=True
use_eigen_sparse=True
use_glog=False
use_schur_specializations=True
[requires]
eigen/3.4.0#2e192482a8acff96fe34766adca2b24c:da39a3ee5e6b4b0d3255bfef95601890afd80709

ERROR: Missing prebuilt package for 'ceres-solver/2.1.0'
Check the available packages using 'conan list ceres-solver/2.1.0:* -r=remote'
or try to build locally from sources using the '--build=ceres-solver/2.1.0' argument

More Info at 'https://docs.conan.io/2/knowledge/faq.html#error-missing-prebuilt-package'

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

SpaceIm · 2023-05-01T08:23:05Z

ERROR: Missing binary: ceres-solver/2.1.0:de0060c16e17cd1c56cbcceed5a819e6ab30b19b

@RubenRBS could you re-generate v2 packages of ceres-solver please? #16854 has changed RREV of eigen and therefore changed package id of ceres-solver (ceres-solver depends on eigen, and in conan v2 full ref of header-only libs contributes to package id of downstream).

SpaceIm · 2023-05-01T13:25:11Z

Shouldn't be a blocker here, but it's worth noting that compilation fails with C++20 due to usage of https://en.cppreference.com/w/cpp/memory/allocator/construct in public headers of a dependency (coin-lemon):

[85/228] Building CXX object openMVG/sfm/CMakeFiles/openMVG_sfm.dir/pipelines/global/sfm_global_engine_relative_motions.cpp.o
FAILED: openMVG/sfm/CMakeFiles/openMVG_sfm.dir/pipelines/global/sfm_global_engine_relative_motions.cpp.o
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DLEMON_ONLY_TEMPLATES -DOPENMVG_STD_UNORDERED_MAP -DopenMVG_sfm_EXPORTS -I/Users/spaceim/.conan2/p/t/openm243a43d6de290/b/src/src -I/Users/spaceim/.conan2/p/t/openm243a43d6de290/b/src/src/third_party/stlplus3 -I/filesystemSimplified -isystem /Users/spaceim/.conan2/p/eigen3d88c0279cc26/p/include/eigen3 -isystem /Users/spaceim/.conan2/p/cerea4cf7b92f85513/p/include -isystem /Users/spaceim/.conan2/p/coin-f4d42f84a4725/p/include -isystem /Users/spaceim/.conan2/p/flann3d294762a4bf7/p/include -isystem /Users/spaceim/.conan2/p/lz40156eeb4105bc/p/include -isystem /Users/spaceim/.conan2/p/ceres408a6b7f071eb/p/include -isystem /Users/spaceim/.conan2/p/ceres408a6b7f071eb/p/include/ceres -isystem /Users/spaceim/.conan2/p/ceres408a6b7f071eb/p/include/ceres/internal/miniglog -m64 -stdlib=libc++ -O3 -std=c++20 -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk -fPIC -m64 -stdlib=libc++ -MD -MT openMVG/sfm/CMakeFiles/openMVG_sfm.dir/pipelines/global/sfm_global_engine_relative_motions.cpp.o -MF openMVG/sfm/CMakeFiles/openMVG_sfm.dir/pipelines/global/sfm_global_engine_relative_motions.cpp.o.d -o openMVG/sfm/CMakeFiles/openMVG_sfm.dir/pipelines/global/sfm_global_engine_relative_motions.cpp.o -c /Users/spaceim/.conan2/p/t/openm243a43d6de290/b/src/src/openMVG/sfm/pipelines/global/sfm_global_engine_relative_motions.cpp
In file included from /Users/spaceim/.conan2/p/t/openm243a43d6de290/b/src/src/openMVG/sfm/pipelines/global/sfm_global_engine_relative_motions.cpp:12:
In file included from /Users/spaceim/.conan2/p/t/openm243a43d6de290/b/src/src/openMVG/graph/graph.hpp:12:
In file included from /Users/spaceim/.conan2/p/coin-f4d42f84a4725/p/include/lemon/connectivity.h:22:
In file included from /Users/spaceim/.conan2/p/coin-f4d42f84a4725/p/include/lemon/dfs.h:26:
In file included from /Users/spaceim/.conan2/p/coin-f4d42f84a4725/p/include/lemon/list_graph.h:28:
In file included from /Users/spaceim/.conan2/p/coin-f4d42f84a4725/p/include/lemon/bits/graph_extender.h:25:
In file included from /Users/spaceim/.conan2/p/coin-f4d42f84a4725/p/include/lemon/bits/default_map.h:23:
/Users/spaceim/.conan2/p/coin-f4d42f84a4725/p/include/lemon/bits/array_map.h:91:19: error: no member named 'construct' in 'std::allocator<lemon::concepts::MappableDigraphComponent<lemon::concepts::BaseGraphComponent>::Constraints<lemon::ListGraph>::Dummy>'
        allocator.construct(&(values[id]), Value());
        ~~~~~~~~~ ^

I guess it's related to #15515 which #15516 tried to address.

SpaceIm · 2023-05-01T17:14:35Z

@uilianries @prince-chrismc @SSE4 @jwillikers could you review this one please? It's ready for 1 month, and I don't think it can pass v2 pipeline on Linux without a fix of conan-io/conan#13560 in conan client.

I can try a workaround for this Linux issue (inject VirtualRunEnv in build scope).

prince-chrismc

I very very very quickly glanced at this and nothing glared at me, this will go in the progress over perfection bucket today :)

* add openmvg/2.0 * drop gcc < 7 * fix build for non-x86 archs * inject __SSE2__ for msvc if x86 * add /bigobj for openMVG_multiview compilation * add short_paths * bigobj for openMVG_matching as well * more accurate check of ceres-solver version regarding C++14 * bump libtiff

conan-center-bot added the Service Under Maintenance label Mar 3, 2023