-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gst-plugins-base: Conan V2 support #17656
Conversation
I detected other pull requests that are modifying gst-plugins-base/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
self.requires("glib/2.72.0") | ||
self.requires("gstreamer/1.19.2") | ||
self.requires("glib/2.76.2", transitive_headers=True, transitive_libs=True) | ||
self.requires("gstreamer/1.19.2", transitive_headers=True, transitive_libs=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a problem with this dependency, the gst-plugins-base version is completely tied to the GStreamer version, you need something like:
self.requires(f"gstreamer/{self.version}")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thank you! I'll do that. I'm also going to add something to the validate
method to check this in the case of an override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Blocked by #18162 |
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This comment has been minimized.
This comment has been minimized.
Blocked until #20795 is merged |
This comment has been minimized.
This comment has been minimized.
692bbcd
to
fd8d31d
Compare
This comment has been minimized.
This comment has been minimized.
Update dependencies. Add glib as a tool_requires for glib-mkenums. Add wayland as a tool_requiers for wayland-scanner.
fd8d31d
to
5dcbc99
Compare
Conan v1 pipeline ❌Failure in build 8 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Failure in build 8 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Update dependencies.
Add glib as a tool_requires for glib-mkenums.
Add wayland as a tool_requiers for wayland-scanner.
Specify library name and version: gst-plugins-base/*
Requires PR #20795.